Skip to content

Update version when bulk param is available in ES stats API#18459

Merged
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:mb-es-index-stats-bulk-upd-version
May 15, 2020
Merged

Update version when bulk param is available in ES stats API#18459
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:mb-es-index-stats-bulk-upd-version

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented May 12, 2020

What does this PR do?

Updates the minimum version of Elasticsearch that allows the GET _stats API to accept the bulk parameter.

Why is it important?

Elasticsearch added the new bulk parameter to the GET _stats API in elastic/elasticsearch#52208. That PR has been merged so this parameter is available in master / 8.0.0 of Elasticsearch. However, that PR has not yet been backported (see elastic/elasticsearch#55447), so this parameter is not available in earlier versions of Elasticsearch yet.

So for now we tell the elasticsearch Metricbeat module to only add the bulk parameter to the GET _stats API call request if the version of Elasticsearch it's talking to is 8.0.0 or higher.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works Parity tests should start passing once this PR is merged.
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. The feature that introduced this bug will be released in 7.8.0. Since that hasn't yet been released yet, no CHANGELOG entry for the bugfix is necessary.

@ycombinator ycombinator added bug needs_backport PR is waiting to be backported to other branches. [zube]: In Review Feature:Stack Monitoring v8.0.0 Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v7.9.0 labels May 12, 2020
@ycombinator ycombinator requested a review from chrisronline May 12, 2020 16:47
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring (Stack monitoring)

@ycombinator ycombinator removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3022
Skipped 756
Total 3778

@ycombinator
Copy link
Copy Markdown
Contributor Author

run tests

@ycombinator ycombinator merged commit 1dde9f4 into elastic:master May 15, 2020
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label May 15, 2020
@ycombinator ycombinator deleted the mb-es-index-stats-bulk-upd-version branch May 15, 2020 15:22
ycombinator added a commit that referenced this pull request May 19, 2020
…18588)

* Update version when bulk param is available in ES stats API

* Updating unit tests
ycombinator added a commit that referenced this pull request May 19, 2020
…18589)

* Update version when bulk param is available in ES stats API

* Updating unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants