Cherry-pick #16903 to 7.x: [Agent] Inject index with sane defaults to configuration #17579
Merged
ph merged 1 commit intoelastic:7.xfrom Apr 7, 2020
ph:backport_16903_7.x
Merged
Cherry-pick #16903 to 7.x: [Agent] Inject index with sane defaults to configuration #17579ph merged 1 commit intoelastic:7.xfrom ph:backport_16903_7.x
ph merged 1 commit intoelastic:7.xfrom
ph:backport_16903_7.x
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
michalpristas
approved these changes
Apr 7, 2020
Contributor
michalpristas
left a comment
michalpristas
left a comment
There was a problem hiding this comment.
Including new config looks OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16903 to 7.x branch. Original message:
Migrated from: #15852
Build on top of: #15809
Added one extra rule for injecting index into inputs based on provided type and detected namespace/dataset type.
Other option was to use decorator but at the time of decorating there are already some pieces of config missing.
Draft until final configuration format is settled and mentioned PR is in, but READY for review.
It overwrites index specified in input.
Fixes: #15690
Fixes: #15691
cc @ruflin @ph