[Agent] Rule extracting items from array#15809
Merged
michalpristas merged 4 commits intoelastic:fleetfrom Jan 28, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest (Project:fleet) |
houndci-bot
reviewed
Jan 24, 2020
ph
approved these changes
Jan 27, 2020
| r = &ExtractListItemRule{} | ||
| if err := unpack(fields, r); err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
looking at the method, its a problem with all the cases statement of the switch case, we could do:
Suggested change
| } | |
| return unpack(fields, r) |
Contributor
Author
There was a problem hiding this comment.
we cant return just but i will change it to less chatty way
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
[Agent] Rule extracting items from array (elastic#15809)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractListItemRuleextract items with specified name from a list of maps.The result is store in a new array.
Example:
Source:
Called
For extracting
inputfields fromstreamslist and storing it in new list namedinputsresult:
cc #15690