Cherry-pick #16616 to 7.x: Vendor Agent dependencies#16730
Closed
ph wants to merge 1 commit intoelastic:7.xfrom
ph:backport_16616_7.x
Closed
Cherry-pick #16616 to 7.x: Vendor Agent dependencies#16730ph wants to merge 1 commit intoelastic:7.xfrom ph:backport_16616_7.x
ph wants to merge 1 commit intoelastic:7.xfrom
ph:backport_16616_7.x
Conversation
Contributor
|
Pinging @elastic/ingest (Project:fleet) |
michalpristas
approved these changes
Mar 3, 2020
ruflin
approved these changes
Mar 3, 2020
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM, besides the merge conflict.
Contributor
There was a problem hiding this comment.
@urso Should we bring this into a elastic repo long term?
There was a problem hiding this comment.
Long term and if there is still interest in ecslog, yes.
|
@ph looks like switch to go modules to add a conflict. |
Contributor
Author
|
yeah, didn't have conflict yesterday rebasing it. |
* Vendor Agent dependencies This PR is only the dependencies required by the Agent. * Fix missing/bad ecslog dependencies (cherry picked from commit a25903b)
Contributor
Author
|
rebased waiting for ci green to merge |
Contributor
Author
|
going to close this, with the introduction of go module it will break this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16616 to 7.x branch. Original message:
This PR is only the dependencies required by the Agent. We do this to simplify the Agent PR itself and to facilitate future backport to 7.x
What does this PR do?
Why is it important?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs