Vendor Agent dependencies#16616
Conversation
|
Pinging @elastic/ingest (Project:fleet) |
|
Dependencies added: antlr4: 👍 urso/ecslog: Please update to recent ecslog. The one you are vendoing is older and still contains some bugs. The update will bring in urso/diag, urso/diag-ecs, and urso/sderr (functinoality has been split up). The testing with these is much improved and minor bugs and stability issues have been fixed. hashicorp/errwrap: Do we need this? We already have github.com/pkg/errors which provides Wrap function. hashicorp/go-multierror: Do we need this? We already have go.uber.org/multierr Ecslog (functionality has been moved to sderr) provides functionality from multiple error packages in one package only. Plus it is compatible to the recent Go2 proposal (pkg/errors is deprecated and unmaintained), supports multiline printing via |
|
I will update ecslog since this should not have any impact on our code but for errwrap and multierror I will make a followup. I don't want to do refactor and merge on master at the same time. |
|
errwrap is not used so we might clean this up, but go-multierror is used and i would keep it there and address later outside of this PR. To keep migration simple. |
|
@urso dependecies updated and errwrap removed. |
|
Looks like govendor did mess with you :) |
|
@urso You have no idea how I hate that tool. |
For me the tool just hangs for some projects I want to update. tried on windows/linux/mac, with new gopath... So I sometimes resort to update the json by hand. No idea who is more lucky :P |
Both of us are not, I am not even sure if god mod will fix all theses problems. Anyway, I've fixed the dependencies related to ecs. |
This PR is only the dependencies required by the Agent.
|
merging failure aren't related to this change. |
This PR is only the dependencies required by the Agent. We do this to simplify the Agent PR itself and to facilitate future backport to 7.x
What does this PR do?
Why is it important?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs