Cherry-pick #16554 to 7.6: Fix k8s pod annotations tier in metadata #16572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 83e7957)
blakerouse
approved these changes
Feb 25, 2020
Contributor
blakerouse
left a comment
blakerouse
left a comment
There was a problem hiding this comment.
Looks good, other then the fix in the changelog.
|
|
||
| - Fix k8s pods labels broken schema. {pull}16480[16480] | ||
| - Fix k8s pods annotations broken schema. {pull}16554[16554] | ||
| - Upgrade go-ucfg to latest v0.8.3. {pull}16450{16450} |
Contributor
There was a problem hiding this comment.
This is not from this PR.
Contributor
|
Did we close this unmerged (and what does it mean for the 7.6.1)? |
Member
Author
|
Hey there were some issues with GH and backporting script was not working properly so I rerun the script. Here is the safe one: #16581 Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16554 to 7.6 branch. Original message:
Follow-up of #16480 PR.
It was found also that
kubernetes.annotations.*do not follow the schema defined atbeats/libbeat/processors/add_kubernetes_metadata/_meta/fields.yml
Line 38 in 2e4d292
This PR aims to fix it.
Not sure if we should fix it in general for all resources at
beats/libbeat/common/kubernetes/metadata/resource.go
Line 105 in dba8f74