Fix k8s pod annotations tier in metadata #16554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
bug
needs_backport
exekias
approved these changes
Feb 25, 2020
Signed-off-by: chrismark <[email protected]>
Member
Author
|
Jenkins build was successful for linux, merging this one. |
1 similar comment
Member
Author
|
Jenkins build was successful for linux, merging this one. |
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 83e7957)
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 83e7957)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 83e7957)
ChrsMark
added a commit
that referenced
this pull request
Feb 26, 2020
ChrsMark
added a commit
that referenced
this pull request
Feb 26, 2020
This was referenced Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #16480 PR.
It was found also that
kubernetes.annotations.*do not follow the schema defined atbeats/libbeat/processors/add_kubernetes_metadata/_meta/fields.yml
Line 38 in 2e4d292
This PR aims to fix it.
Not sure if we should fix it in general for all resources at
beats/libbeat/common/kubernetes/metadata/resource.go
Line 105 in dba8f74