Add context to Kibana client Send method.#16515
Merged
simitt merged 3 commits intoelastic:masterfrom Feb 25, 2020
Merged
Conversation
This allows passing in context for http requests made to Kibana. Requirement for elastic/apm-server#3185
2 tasks
|
Maybe it is better to introduce a |
urso
approved these changes
Feb 24, 2020
Contributor
Author
|
Merging this in as failing tests are unrelated. |
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 25, 2020
This allows passing in context for http requests made to Kibana. Requirement for elastic/apm-server#3185
simitt
added a commit
that referenced
this pull request
Feb 25, 2020
This allows passing in context for http requests made to Kibana. Requirement for elastic/apm-server#3185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows passing in context for http requests made to Kibana.
Requirement for elastic/apm-server#3185
This PR supersedes #16427. It only adds minimal required changes to avoid vendoring the apm library without a real usecase for other beats.
Why is it important?
APM Server uses the Kibana client for regular queries and wants to add instrumentation to the requests for more insights. Proper context passing is a requirement for instrumenting the requests.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
The changes of this PR are part of elastic/apm-server#3359, where it is shown how this can be tested in combination with APM Server.
Related issues
APM Server Issue # elastic/apm-server#3185