Skip to content

Basic Kibana client apm instrumentation#16427

Closed
simitt wants to merge 5 commits intoelastic:masterfrom
simitt:add-apm
Closed

Basic Kibana client apm instrumentation#16427
simitt wants to merge 5 commits intoelastic:masterfrom
simitt:add-apm

Conversation

@simitt
Copy link
Copy Markdown
Contributor

@simitt simitt commented Feb 19, 2020

What does this PR do?

Vendor go.elastic.co/apm and add context to Kibana client Send method. If the passed in context includes an APM transaction the outgoing Kibana request will be recorded as span.

Use context.TODO() where no starting context is currently available.

Why is it important?

This lays the groundwork for adding instrumentation to outgoing calls to Kibana. At the moment,
the beats use the Kibana connection only for one-off requests, such as loading dashboards. APM Server uses it for regular queries to Kibana where adding instrumentation helps gaining more insights into these requests.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Add changelog entry

Related issues

Precondition for elastic/apm-server#3185

Vendor go.elastic.co/apm and add context to Kibana client
Send method. If the passed in context includes an APM
transaction the outgoing Kibana request will be recorded as span.

Use context.TODO() where no starting context is currently available.
@simitt
Copy link
Copy Markdown
Contributor Author

simitt commented Feb 19, 2020

jenkins run the tests again

@simitt simitt marked this pull request as ready for review February 20, 2020 11:45
@simitt simitt requested a review from urso February 20, 2020 11:46
@urso
Copy link
Copy Markdown

urso commented Feb 21, 2020

LGTM. Can you please add some instructions to the PR description about testing and how to configure?

@urso
Copy link
Copy Markdown

urso commented Feb 21, 2020

Please check formatting or go vet. The intake job is complaining with:

14:44:39 >> check: Checking source code for common problems
14:44:43 Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [auditbeat/auditbeat.reference.yml]
14:44:43 ../libbeat/scripts/Makefile:143: recipe for target 'check' failed
14:44:43 make[1]: Leaving directory '/var/lib/jenkins/workspace/elastic+beats+pull-request+multijob-intake/src/github.com/elastic/beats/auditbeat'
14:44:43 make[1]: *** [check] Error 1
14:44:43 Makefile:92: recipe for target 'check' failed
14:44:43 Running cleanup...

@simitt
Copy link
Copy Markdown
Contributor Author

simitt commented Feb 24, 2020

I decided to go with the minimal required changes. This is superseded by #16515.

@simitt simitt closed this Feb 24, 2020
@simitt simitt deleted the add-apm branch July 16, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants