Basic Kibana client apm instrumentation#16427
Closed
simitt wants to merge 5 commits intoelastic:masterfrom
Closed
Conversation
Vendor go.elastic.co/apm and add context to Kibana client Send method. If the passed in context includes an APM transaction the outgoing Kibana request will be recorded as span. Use context.TODO() where no starting context is currently available.
5 tasks
Contributor
Author
|
jenkins run the tests again |
|
LGTM. Can you please add some instructions to the PR description about testing and how to configure? |
|
Please check formatting or |
1 task
Contributor
Author
|
I decided to go with the minimal required changes. This is superseded by #16515. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Vendor go.elastic.co/apm and add context to Kibana client Send method. If the passed in context includes an APM transaction the outgoing Kibana request will be recorded as span.
Use context.TODO() where no starting context is currently available.
Why is it important?
This lays the groundwork for adding instrumentation to outgoing calls to Kibana. At the moment,
the beats use the Kibana connection only for one-off requests, such as loading dashboards. APM Server uses it for regular queries to Kibana where adding instrumentation helps gaining more insights into these requests.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
Related issues
Precondition for elastic/apm-server#3185