Skip to content

Cherry-pick #16476 to 7.6: match reference.yml to code default#16485

Merged
urso merged 1 commit intoelastic:7.6from
urso:backport_16476_7.6
Feb 21, 2020
Merged

Cherry-pick #16476 to 7.6: match reference.yml to code default#16485
urso merged 1 commit intoelastic:7.6from
urso:backport_16476_7.6

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Feb 21, 2020

Cherry-pick of PR #16476 to 7.6 branch. Original message:

What does this PR do?
Changes the default for setup.ilm.check_exists from false to true to match the code defaults. Closes issue #16474

The code defaults are in https://github.com/elastic/beats/blob/7.6/libbeat/_meta/config.reference.yml.tmpl#L978-L981

Why is it important?

Users depend on .reference.yml to be correct as they use it as a template for their own config files.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

(the code defaults and docs are already correct, just the reference.yml files are wrong). The code checks are already there.

Author's Checklist

  • Someone should verify that the template file I modified is used to generate all of the .reference.yml files, I do not know how to do this.

How to test this PR locally

Related issues

@urso urso merged commit 4796fef into elastic:7.6 Feb 21, 2020
@urso urso deleted the backport_16476_7.6 branch February 21, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants