Skip to content

match reference.yml to code default#16476

Merged
urso merged 1 commit intoelastic:masterfrom
DanRoscigno:master
Feb 21, 2020
Merged

match reference.yml to code default#16476
urso merged 1 commit intoelastic:masterfrom
DanRoscigno:master

Conversation

@DanRoscigno
Copy link
Copy Markdown
Contributor

@DanRoscigno DanRoscigno commented Feb 21, 2020

What does this PR do?
Changes the default for setup.ilm.check_exists from false to true to match the code defaults. Closes issue #16474

The code defaults are in https://github.com/elastic/beats/blob/7.6/libbeat/_meta/config.reference.yml.tmpl#L978-L981

Why is it important?

Users depend on .reference.yml to be correct as they use it as a template for their own config files.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

(the code defaults and docs are already correct, just the reference.yml files are wrong). The code checks are already there.

Author's Checklist

  • Someone should verify that the template file I modified is used to generate all of the .reference.yml files, I do not know how to do this.

How to test this PR locally

Related issues

@DanRoscigno DanRoscigno requested a review from urso February 21, 2020 01:21
@urso urso added needs_backport PR is waiting to be backported to other branches. review Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 21, 2020
@urso
Copy link
Copy Markdown

urso commented Feb 21, 2020

Thank you!

@urso urso merged commit 523528b into elastic:master Feb 21, 2020
@urso urso mentioned this pull request Feb 21, 2020
Merged
6 tasks
@urso urso added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 21, 2020
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
@DanRoscigno
match reference.yml to code default (elastic#16476)
c387b05 
(cherry picked from commit 523528b)
@urso urso mentioned this pull request Feb 21, 2020
Merged
6 tasks
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
@DanRoscigno
match reference.yml to code default (elastic#16476)
a99559b 
(cherry picked from commit 523528b)
@urso urso added the v7.6.1 label Feb 21, 2020
urso pushed a commit that referenced this pull request Feb 21, 2020
@DanRoscigno
Cherry-pick #16476 to 7.6: match reference.yml to code default (#16485)
4796fef 
(cherry picked from commit 523528b)

Co-authored-by: Dan Roscigno <dan@roscigno.com>
urso pushed a commit that referenced this pull request Feb 21, 2020
@DanRoscigno
Cherry-pick #16476 to 7.x: match reference.yml to code default (#16484)
4066e33 
(cherry picked from commit 523528b)

Co-authored-by: Dan Roscigno <dan@roscigno.com>
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
Revert "match reference.yml to code default (elastic#16476)"
3b272cd 
This reverts commit 523528b.
urso pushed a commit that referenced this pull request Feb 21, 2020
Revert "match reference.yml to code default (#16476)" (#16486)
e1235c1 
This reverts commit 523528b.
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
@DanRoscigno
match reference.yml to code default (elastic#16476)
f4f5fe4
@urso urso mentioned this pull request Feb 21, 2020
Merged
urso pushed a commit that referenced this pull request Feb 21, 2020
@DanRoscigno
Fixed reference.yml (#16487)
218c330 
* match reference.yml to code default (#16476)

* make update

Co-authored-by: Dan Roscigno <dan@roscigno.com>
@urso urso mentioned this pull request Feb 21, 2020
Merged
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
@DanRoscigno
Fixed reference.yml (elastic#16487)
ab22b75 
* match reference.yml to code default (elastic#16476)

* make update

Co-authored-by: Dan Roscigno <dan@roscigno.com>
(cherry picked from commit 218c330)
@urso urso mentioned this pull request Feb 21, 2020
Merged
urso pushed a commit to urso/beats that referenced this pull request Feb 21, 2020
@DanRoscigno
Fixed reference.yml (elastic#16487)
49d17c2 
* match reference.yml to code default (elastic#16476)

* make update

Co-authored-by: Dan Roscigno <dan@roscigno.com>
(cherry picked from commit 218c330)
urso pushed a commit that referenced this pull request Feb 21, 2020
@DanRoscigno
Cherry-pick #16487 to 7.x: Fixed reference.yml (#16488)
b06cc4f 
* match reference.yml to code default (#16476)

* make update

Co-authored-by: Dan Roscigno <dan@roscigno.com>
(cherry picked from commit 218c330)
urso pushed a commit that referenced this pull request Feb 21, 2020
@DanRoscigno
Cherry-pick #16487 to 7.6: Fixed reference.yml (#16489)
2d80547 
* match reference.yml to code default (#16476)

* make update

Co-authored-by: Dan Roscigno <dan@roscigno.com>
(cherry picked from commit 218c330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@urso urso urso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug review Team:Services (Deprecated) Label for the former Integrations-Services team v7.6.1 v7.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reference.yml files have incorrect default for setup.ilm.check_exists

3 participants

@DanRoscigno @urso @andresrc