Add integration/system tests for Kafka JMX metricsets #14677
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Licensed to Elasticsearch B.V. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. Elasticsearch B.V. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| // +build integration | ||
|
|
||
| package broker | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/elastic/beats/libbeat/tests/compose" | ||
| mbtest "github.com/elastic/beats/metricbeat/mb/testing" | ||
| // Register input module and metricset | ||
| _ "github.com/elastic/beats/metricbeat/module/jolokia" | ||
| _ "github.com/elastic/beats/metricbeat/module/jolokia/jmx" | ||
| ) | ||
|
|
||
| func TestData(t *testing.T) { | ||
| service := compose.EnsureUp(t, "kafka", | ||
| compose.UpWithTimeout(600*time.Second), | ||
| compose.UpWithAdvertisedHostEnvFileForPort(9092), | ||
| ) | ||
|
|
||
| ms := mbtest.NewReportingMetricSetV2Error(t, getConfig(service.HostForPort(8779))) | ||
| err := mbtest.WriteEventsReporterV2Error(ms, t, "") | ||
| if err != nil { | ||
| t.Fatal("write", err) | ||
| } | ||
|
ChrsMark marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| func TestFetch(t *testing.T) { | ||
| service := compose.EnsureUp(t, "kafka", | ||
| compose.UpWithTimeout(600*time.Second), | ||
| compose.UpWithAdvertisedHostEnvFileForPort(9092), | ||
| ) | ||
| reporter := &mbtest.CapturingReporterV2{} | ||
|
|
||
| metricSet := mbtest.NewReportingMetricSetV2Error(t, getConfig(service.HostForPort(8779))) | ||
|
ChrsMark marked this conversation as resolved.
Outdated
|
||
| metricSet.Fetch(reporter) | ||
|
|
||
| e := mbtest.StandardizeEvent(metricSet, reporter.GetEvents()[0]) | ||
| t.Logf("%s/%s event: %+v", metricSet.Module().Name(), metricSet.Name(), e.Fields.StringToPrint()) | ||
| } | ||
|
|
||
| func getConfig(host string) map[string]interface{} { | ||
| return map[string]interface{}{ | ||
| "module": "kafka", | ||
| "metricsets": []string{"broker"}, | ||
| "hosts": []string{host}, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to Elasticsearch B.V. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. Elasticsearch B.V. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package broker | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| "github.com/elastic/beats/metricbeat/mb" | ||
| // Register input module and metricset | ||
| _ "github.com/elastic/beats/metricbeat/module/jolokia" | ||
| _ "github.com/elastic/beats/metricbeat/module/jolokia/jmx" | ||
| ) | ||
|
|
||
| func init() { | ||
| // To be moved to some kind of helper | ||
| os.Setenv("BEAT_STRICT_PERMS", "false") | ||
| mb.Registry.SetSecondarySource(mb.NewLightModulesSource("../../../module")) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,14 @@ input: | |
| attributes: | ||
| - attr: MeanRate | ||
| field: request.fetch.failed_per_second | ||
| - mbean: 'kafka.server:name=FailedProduceRequestsPerSec,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: request.produce.failed | ||
| - mbean: 'kafka.server:name=FailedFetchRequestsPerSec,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: request.fetch.failed | ||
| - mbean: 'kafka.controller:name=LeaderElectionRateAndTimeMs,type=ControllerStats' | ||
| attributes: | ||
| - attr: MeanRate | ||
|
|
@@ -47,19 +55,37 @@ input: | |
| attributes: | ||
| - attr: MeanRate | ||
| field: log.flush_rate | ||
| - mbean: 'kafka.server:name=BytesRejectedPerSec,topic=*,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: topic.net.bytes_rejected | ||
| - mbean: 'kafka.server:name=BytesInPerSec,topic=*,type=BrokerTopicMetrics,topic=*' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: topic.net.bytes_in | ||
| - mbean: 'kafka.server:name=BytesOutPerSec,topic=*,type=BrokerTopicMetrics,topic=*' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: topic.net.bytes_out | ||
| - mbean: 'kafka.server:type=BrokerTopicMetrics,topic=*,name=MessagesInPerSec,topic=*' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: topic.messages_in | ||
| - mbean: 'kafka.server:name=BytesRejectedPerSec,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: net.bytes_rejected | ||
| - mbean: 'kafka.server:name=BytesInPerSec,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: net.bytes_in | ||
| - mbean: 'kafka.server:name=BytesOutPerSec,type=BrokerTopicMetrics' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: net.bytes_out | ||
| - mbean: 'kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec' | ||
| attributes: | ||
| - attr: MeanRate | ||
| field: messages_in | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,15 @@ | |
| - name: bytes_in | ||
| description: The rate of bytes coming in to the consumer | ||
| type: float | ||
| - name: max_lag | ||
| description: The maximum consumer lag | ||
| type: float | ||
| - name: zookeeper_commits | ||
| description: The rate of offset commits to ZooKeeper | ||
| type: float | ||
| - name: kafka_commits | ||
| description: The rate of offset commits to Kafka | ||
| type: float | ||
| - name: messages_in | ||
| description: The rate of consumer message consumption | ||
| type: float | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following field conventions this should probably be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorantis is this ok from product perspective or we should strictly follow the naming provided in the initial issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no strict requirement on the naming. The field names were taken from the ER attached to the original issue. Do we have the mentioned naming convention somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the conventions here: https://www.elastic.co/guide/en/beats/devguide/7.5/event-conventions.html