Add integration/system tests for Kafka JMX metricsets#14677
Merged
ChrsMark merged 15 commits intoelastic:masterfrom Nov 25, 2019
Merged
Add integration/system tests for Kafka JMX metricsets#14677ChrsMark merged 15 commits intoelastic:masterfrom
ChrsMark merged 15 commits intoelastic:masterfrom
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
module
needs_backport
ChrsMark
added
[zube]: In Progress
in progress
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
[zube]: In Review
review
and removed
[zube]: In Progress
in progress
jsoriano
reviewed
Nov 21, 2019
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_jmx_kafka_tests
branch
from
44e8e2e to
46442e0
Compare
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_jmx_kafka_tests
branch
from
13d018b to
9d229cd
Compare
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
requested changes
Nov 25, 2019
Member
jsoriano
left a comment
jsoriano
left a comment
There was a problem hiding this comment.
I think we should better follow conventions for some field names.
Proposed changes in integration tests would be nice to have, but not required.
| - name: topic.messages_in | ||
| description: The incoming message rate per topic | ||
| type: float | ||
| - name: net.bytes_in |
Member
There was a problem hiding this comment.
Following field conventions this should probably be:
Suggested change
| - name: net.bytes_in | |
| - name: net.in.bytes_per_sec |
Member
Author
Contributor
There was a problem hiding this comment.
there's no strict requirement on the naming. The field names were taken from the ER attached to the original issue. Do we have the mentioned naming convention somewhere?
Member
There was a problem hiding this comment.
You can find the conventions here: https://www.elastic.co/guide/en/beats/devguide/7.5/event-conventions.html
| - name: net.bytes_in | ||
| description: The incoming byte rate | ||
| type: float | ||
| - name: net.bytes_out |
Member
There was a problem hiding this comment.
And:
Suggested change
| - name: net.bytes_out | |
| - name: net.out.bytes_per_sec |
| - name: net.bytes_out | ||
| description: The outgoing byte rate | ||
| type: float | ||
| - name: net.bytes_rejected |
Member
There was a problem hiding this comment.
And:
Suggested change
| - name: net.bytes_rejected | |
| - name: net.rejected.bytes_per_sec |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Member
Author
jsoriano
approved these changes
Nov 25, 2019
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Nov 26, 2019
(cherry picked from commit a5d86cb)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration and system tests for Kafka JMX metricsets as a follow-up of #14330