Add Logstash output to functionbeat and refactor Logstash output docs#13818
Add Logstash output to functionbeat and refactor Logstash output docs#13818dedemorton merged 4 commits intoelastic:masterfrom
Conversation
bmorelli25
left a comment
There was a problem hiding this comment.
Good stuff here. A couple questions/recommendations.
Before I give this the green thumb, I need to make sure nothing explodes on the APM side. I'm going to check this out and run our make update-beats-docs command to be sure.
|
Pending that If you're curious: elastic/apm-server#2744. |
|
One final APM Server request: Can you please comment out the beats/libbeat/docs/command-reference.asciidoc Line 657 in dc99773 And here: beats/libbeat/docs/command-reference.asciidoc Line 761 in dc99773 These should be changed to: and This was my fault. |
bmorelli25
left a comment
There was a problem hiding this comment.
Pending the changes above, LGTM!
|
+100 on separate files per output. To me it looks like things got mostly copied around. I wonder if this is also an opportunity to refine symbols used by our docs. Especially with settings like 'timeout', some hierarchy can be import to guarantee we always have the correct anchors. For reference documentation (like the output), I'd like the symbol naming follow the actual setting names (makes it easier to search). For example: |
@urso That's a good idea, but I'd prefer to defer that level of refactoring because I want to have this PR merged by Monday in preparation for the release. I still have other stuff to do. :-/ I will rename the attributes as you suggest, but other renaming should wait until I have more time. |
|
@urso I've added your request to the meta issue that I have open to track additional refactoring. We will need to be careful here because we don't want to inadvertently change anchor IDs that affect URLs (setting up redirects is possible, but kind of a pain). In fact, it might make more sense to do this for Beats agent rather than refactoring the existing content. |
|
Doc changes have passed (no code changes) so I'm merging. |
…elastic#13818) * Refactor logstash output docs * Add logstash output to functionbeat * Fix conditional coding to be more flexible * Resolve review feedback
…elastic#13818) (elastic#13838) * Refactor logstash output docs * Add logstash output to functionbeat * Fix conditional coding to be more flexible * Resolve review feedback
This PR:
libbeat-dirattribute to usedocdiras base to make the paths more absolute (makes it easier to move files around).