Skip to content

[docs] Break outputconfig.asciidoc into multiple files#2744

Merged
bmorelli25 merged 6 commits intoelastic:masterfrom
bmorelli25:update-output-config-docs
Sep 30, 2019
Merged

[docs] Break outputconfig.asciidoc into multiple files#2744
bmorelli25 merged 6 commits intoelastic:masterfrom
bmorelli25:update-output-config-docs

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Sep 27, 2019

This PR accomplishes the following:

  • 0721682 - Runs make update-beats-docs for the old outputconfig.asciidoc file. This allows us to easily see in the diff any changes that are happening (there aren't many).
  • 9acd9b8 - The make docs script needs to be updated to use asciidoctor. This will be persisted in the Beats repo in a different PR.
  • 6765ce5 & 2d4d224 - Breaks up the outputconfig.asciidoc file into multiple files -- one per output. This will allow us to be a lot more flexible with this documentation when the need arises.

This PR is a follow up to elastic/beats#13818, and should only be merged after it has been merged.

@bmorelli25
Copy link
Member Author

The HTML diff on this looks good to me:

+5 -5 en/apm/server/master/_manually_loading_template_configuration.html
+1 -2 en/apm/server/master/command-line-options.html
+1 -1 en/apm/server/master/configuration-output-codec.html
+3 -3 en/apm/server/master/configure-cloud-id.html
+4 -3 en/apm/server/master/configuring-output.html
+3 -3 en/apm/server/master/console-output.html
+22 -22 en/apm/server/master/elasticsearch-output.html
+7 -7 en/apm/server/master/file-output.html
+13 -13 en/apm/server/master/kafka-output.html
+22 -22 en/apm/server/master/logstash-output.html
+6 -4 en/apm/server/master/monitoring-internal-collection.html

The changes you're seeing are all "edit" links updating to the new file locations.

@codecov-io
Copy link

Codecov Report

Merging #2744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          82       82           
  Lines        4282     4282           
=======================================
  Hits         3364     3364           
  Misses        918      918

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af426f...7d943d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants