[docs] Break outputconfig.asciidoc into multiple files#2744
Merged
bmorelli25 merged 6 commits intoelastic:masterfrom Sep 30, 2019
Merged
[docs] Break outputconfig.asciidoc into multiple files#2744bmorelli25 merged 6 commits intoelastic:masterfrom
bmorelli25 merged 6 commits intoelastic:masterfrom
Conversation
Member
Author
|
The HTML diff on this looks good to me: The changes you're seeing are all "edit" links updating to the new file locations. |
Codecov Report
@@ Coverage Diff @@
## master #2744 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 82 82
Lines 4282 4282
=======================================
Hits 3364 3364
Misses 918 918Continue to review full report at Codecov.
|
This was referenced Oct 1, 2019
bmorelli25
added a commit
that referenced
this pull request
Oct 2, 2019
bmorelli25
added a commit
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following:
make update-beats-docsfor the oldoutputconfig.asciidocfile. This allows us to easily see in the diff any changes that are happening (there aren't many).make docsscript needs to be updated to use asciidoctor. This will be persisted in the Beats repo in a different PR.outputconfig.asciidocfile into multiple files -- one per output. This will allow us to be a lot more flexible with this documentation when the need arises.This PR is a follow up to elastic/beats#13818, and should only be merged after it has been merged.