Extend logstash.node_stats metricset for logstash_stats stack monitoring data #11511
Conversation
There was a problem hiding this comment.
don't use an underscore in package name
ycombinator
added
Metricbeat
|
Pinging @elastic/stack-monitoring |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Do you plan to also expand the metrics collected by non-xpack?
|
|
||
| type commonStats struct { | ||
| Events map[string]interface{} `json:"events"` | ||
| JVM map[string]interface{} `json:"jvm"` |
There was a problem hiding this comment.
@felixbarny @axw Just found some more jvm metrics. I wonder if long term this also ties into our metrics discussion: elastic/ecs#474
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
Tested and reviewed. Looks great!
@ruflin Not right away. I want to deliberately keep this set minimal to start out. It's easier to add more later than take away ones we don't need. So I'd rather add metrics as/when users request them. |
|
Chatted with @ruflin off-PR and he's given his LGTM. So I'm going ahead with the merge. |
ycombinator
removed
the
needs_backport
5 participants
This PR extends the
node_statsmetricset in thelogstashmetricbeat module. It teaches it to understand thexpack.enabledsetting inmodules.d/logstash.yml. If this setting is set, the metricset indexeslogstash_statsdocuments in.monitoring-logstash-*indices.Resolves partially: #7035
Testing this PR
Start up a Logstash node running one or more pipelines.
Build Metricbeat with this PR:
Enable the logstash Metricbeat module:
Note:
metricbeat modules enable logstash-xpackwill not work as it has not been implemented yet.Configure the logstash Metricbeat module for X-Pack Monitoring. To do this, edit
modules.d/logstash.ymland add the following line to it:Start Metricbeat:
Query the
.monitoring-logstash-7-mb-*indices to make sure there are documents withtype: logstash_stats.Repeat the query in 6. above multiple times over the course of a minute or so. Make sure the number of documents grows over time. New documents of
type:logstash_statsshould be created every 10 seconds (corresponding to the defaultperiodinmodules.d/logstash.yml).