Skip to content

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jun 25, 2019

Similar to #12386 but for the logstash module.

When the logstash metricbeat module is enabled and the xpack.enabled flag in the module configuration is set to true, an exact set of metricsets is required to be configured for Stack Monitoring to work correctly. This PR implements the necessary validation.

…is set to `true`.

When the `logstash` metricbeat module is enabled and the `xpack.enabled` flag in the module configuration is set to `true`, an exact set of metricsets is required to be configured for Stack Monitoring to work correctly. This PR implements the necessary validation.
@ycombinator ycombinator marked this pull request as ready for review June 26, 2019 20:52
@ycombinator ycombinator requested a review from a team as a code owner June 26, 2019 20:52
@ycombinator ycombinator requested review from cachedout and ruflin June 26, 2019 20:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ycombinator ycombinator merged commit 5b1c1ab into elastic:master Jun 26, 2019
@ycombinator ycombinator deleted the mb-ls-xpack-validation branch June 26, 2019 21:36
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants