Extend logstash.node metricset for logstash_state stack monitoring data #11506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
changed the title
39 tasks
ycombinator
added
review
needs_backport
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
Author
|
jenkins, test this |
chrisronline
approved these changes
Apr 2, 2019
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
LGTM! I tested the functionality through the directions below and didn't see any new documents created until I restarted the pipeline
Contributor
|
I've both reviewed the code and tested this PR and it's a 👍 from me. Nice work, @ycombinator ! |
cachedout
approved these changes
Apr 2, 2019
Contributor
Author
|
Will wait for elastic/logstash#10561 to be resolved and CI to go green on this PR before merging. |
This was referenced Jun 25, 2019
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on elastic/logstash#10561. Do not merge until elastic/logstash#10561 is resolved first.
This PR extends the
nodemetricset in thelogstashmetricbeat module. It teaches it to understand thexpack.enabledsetting inmodules.d/logstash.yml. If this setting is set, the metricset indexeslogstash_statedocuments in.monitoring-logstash-*indices.Resolves partially: #7035
Testing this PR
Start up a Logstash node (built with Refactoring of LIR serializer and exposing pipeline metrics logstash#10561) running one or more pipelines.
Build Metricbeat with this PR:
Enable the
logstashMetricbeat module:Configure the
logstashMetricbeat module for X-Pack Monitoring. To do this, editmodules.d/logstash.ymland add the following line to it:Start Metricbeat:
Query the
.monitoring-logstash-7-mb-*indices to make sure there are as many documents withtype: logstash_stateas there are running Logstash pipelines.Repeat the query in 6. above multiple times over the course of a minute or so. Make sure the number of documents stays constant over time. New documents of
type:logstash_stateshould only be created if either the shape of one of the Logstash pipelines changes or the pipeline is restarted.