Skip to content

Multiply also the sum in the prometheus multiplier option #11111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsoriano merged 1 commit into from
Mar 13, 2019
Merged

Multiply also the sum in the prometheus multiplier option #11111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions metricbeat/helper/prometheus/metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,10 @@ func (o opMultiplyBuckets) Process(field string, value interface{}, labels commo
if !ok {
return field, value, labels
}
sum, ok := histogram["sum"].(float64)
if !ok {
return field, value, labels
}
multiplied := common.MapStr{}
for k, v := range bucket {
if f, err := strconv.ParseFloat(k, 64); err == nil {
Expand All @@ -299,5 +303,6 @@ func (o opMultiplyBuckets) Process(field string, value interface{}, labels commo
}
}
histogram["bucket"] = multiplied
histogram["sum"] = sum * o.multiplier
return field, histogram, labels
}
2 changes: 1 addition & 1 deletion metricbeat/helper/prometheus/prometheus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ func TestPrometheus(t *testing.T) {
"1000": uint64(3),
"+Inf": uint64(5),
},
"sum": 4.31,
"sum": 4310.0,
},
},
},
Expand Down