Multiply also the sum in the prometheus multiplier option#11111
Merged
jsoriano merged 1 commit intoelastic:masterfrom Mar 13, 2019
Merged
Multiply also the sum in the prometheus multiplier option#11111jsoriano merged 1 commit intoelastic:masterfrom
jsoriano merged 1 commit intoelastic:masterfrom
Conversation
jsoriano
added
bug
review
Metricbeat
Contributor
|
Will this need a changelog? @kaiyan-sheng could you have a look as you reviewed the other PR if I remember correctly. |
Member
|
Hello, since this will be used on #10585, do we have any update?🙂 |
Contributor
|
@ChrsMark Jaime should be back tomorrow. |
ruflin
approved these changes
Mar 13, 2019
Member
Author
|
Yeah, I am back 😄 Changelog shouldn't be needed as is a fix for an unreleased feature. |
kaiyan-sheng
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prometheus multiplier added in #10994 should multiply histogram sum too to be consistent.