[Heartbeat] Fix status for TCP checks#10777
Merged
andrewvc merged 2 commits intoelastic:6.7from Mar 6, 2019
Merged
Conversation
andrewvc
added
bug
backport
Heartbeat
Team:obs-ds-hosted-services
Contributor
|
Pinging @elastic/uptime |
houndci-bot
reviewed
Feb 15, 2019
Contributor
Author
|
@urso I'm requesting your review since Nicholas will be out, as will I next week. If this looks good please feel free to hit the merge button. |
andrewvc
force-pushed
the
fix-tcp-updown
branch
from
737ec6b to
ff0729b
Compare
Contributor
Author
|
As a note, we'll need to forward port this to 7.0 |
andrewvc
force-pushed
the
fix-tcp-updown
branch
from
ff0729b to
5143c74
Compare
ruflin
reviewed
Mar 5, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
The code LGTM but this will need a changelog entry.
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'. This patch fixes that and adds tests.
This was referenced Mar 7, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 11, 2019
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per `{hostname,port}` instead of once per `{hostname}`. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.
Related (but different) 6.x issue: elastic#10777
Fix import formatting
andrewvc
added a commit
that referenced
this pull request
Mar 11, 2019
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per `{hostname,port}` instead of once per `{hostname}`. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.
Related (but different) 6.x issue: #10777
Fix import formatting
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 11, 2019
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per `{hostname,port}` instead of once per `{hostname}`. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.
Related (but different) 6.x issue: elastic#10777
Fix import formatting
(cherry picked from commit 821baec)
andrewvc
added a commit
that referenced
this pull request
Mar 12, 2019
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per `{hostname,port}` instead of once per `{hostname}`. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.
Related (but different) 6.x issue: #10777
Fix import formatting
(cherry picked from commit 821baec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'.
This patch fixes that and adds tests.