Skip to content

fix: golang-crossbuild requires host specific for arm #16849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v1v merged 3 commits into from
May 8, 2025
Merged

fix: golang-crossbuild requires host specific for arm #16849

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
431af04
fix: golang-crossbuild requires host specific for arm
v1v May 7, 2025
674217e
see https://github.com/elastic/beats/blob/a156701b0302ca0e4e8676d2de9…
v1v May 7, 2025
afc43d0
Use BK env per type of command
v1v May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ notify:
if: "build.state != 'passed'"

env:
PLATFORMS: "darwin/amd64 linux/386 linux/amd64 windows/386 windows/amd64"
IMAGE_UBUNTU_X86_64: "family/core-ubuntu-2004"
IMAGE_UBUNTU_ARM_64: "core-ubuntu-2004-aarch64"
BEAT_DOC_BRANCH: "7.x"
Expand Down
1 change: 0 additions & 1 deletion .buildkite/scripts/package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ PLATFORMS=''
PACKAGES=''
if [[ ${PLATFORM_TYPE} == "arm" || ${PLATFORM_TYPE} == "aarch64" ]]; then
PLATFORMS='linux/arm64'
PACKAGES='docker'
fi

Comment on lines 11 to 12

@v1v v1v May 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLATFORMS was defaulted, henve the BK env variables was not working as expected. Avoid using the script but honour the env variables defined in the Buildkite pipeline itself.

MAKE_GOAL=release-manager-snapshot
Expand Down