fix: golang-crossbuild requires host specific for arm#16849
Merged
Conversation
remove crossbuild for arm4 on amd64
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
v1v
commented
May 7, 2025
kruskall
approved these changes
May 7, 2025
instead of using the script with the logic
v1v
commented
May 8, 2025
Comment on lines
11
to
12
| TYPE="$1" | ||
| PLATFORM_TYPE=$(uname -m) | ||
|
|
||
| PLATFORMS='' | ||
| PACKAGES='' | ||
| if [[ ${PLATFORM_TYPE} == "arm" || ${PLATFORM_TYPE} == "aarch64" ]]; then | ||
| PLATFORMS='linux/arm64' | ||
| PACKAGES='docker' | ||
| fi | ||
|
|
Member
Author
There was a problem hiding this comment.
PLATFORMS was defaulted, henve the BK env variables was not working as expected. Avoid using the script but honour the env variables defined in the Buildkite pipeline itself.
Member
Author
|
It works: 
probably something in the scripts when no DRA is needed... but for now I think this PR is good to go |
kruskall
approved these changes
May 8, 2025
rubvs
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove crossbuild for arm4 on amd64
Motivation/summary
See elastic/golang-crossbuild#560
Checklist
For functional changes, consider:
How to test these changes
Related issues