Conversation
|
The libbeat side has been merged already. Rebase, not squash this one. |
graphaelli
left a comment
graphaelli
left a comment
There was a problem hiding this comment.
looks great, just minor issues
|
|
changelogs/head.asciidoc
Outdated
| - Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057]. | ||
| - Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991]. | ||
| - Add optional `span.subtype` and `span.action` properties. {pull}1618[1618]. | ||
| - Build X-Pack binaries. {pull}1645[1645]. |
There was a problem hiding this comment.
@graphaelli do you think this is appropriate?
There was a problem hiding this comment.
I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.
There was a problem hiding this comment.
Build default distribution under the Elastic License
There was a problem hiding this comment.
awesome, many thanks for checking!
changelogs/head.asciidoc
Outdated
| - Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057]. | ||
| - Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991]. | ||
| - Add optional `span.subtype` and `span.action` properties. {pull}1618[1618]. | ||
| - Build X-Pack binaries. {pull}1645[1645]. |
There was a problem hiding this comment.
I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.
2 participants
No description provided.