Conversation
script/update_beats.sh
Outdated
| --exclude="dev-tools/jenkins_ci.ps1" \ | ||
| --exclude="dev-tools/jenkins_intake.sh" \ | ||
| --exclude="dev-tools/packaging/preference-pane/***" \ | ||
| --exclude="dev-tools/packaging/packages.yml |
There was a problem hiding this comment.
I don't feel this is the right way to do it... would it be better to exclude the whole packaging folder altogether, or to find another way to pass the right path?
There was a problem hiding this comment.
I wonder if there is a way to avoid having to customize this altogether? For now, I think this needs a trailing slash?
There was a problem hiding this comment.
in beats the structure is:
`beats`
`beat1`
`beatN`
`x-pack`
`beat1`
`beatN`
for us is:
`apm-server`
`x-pack`
`apm-server`
so we don't need the .. here: 4530fa0#diff-2a90996ecc944753a4353cab58ca5295L398
... i don't see a way around it, other than changing the structure to match the one from beats which doesn't really make sense:
`some-top-dir`
`apm-server`
`x-pack`
`apm-server`
|
@graphaelli would be great if you can have a look, particularly at the 3rd commit. |
|
note: when the time comes, rebase and merge, not squash |
|
A beats update should be fine. Please let me know if |
4530fa0 to
1250fb5
Compare
1250fb5 to
21903cc
Compare
|
redirect #1645 |
This is needed for the first part of central config: incorporate the
enrollcommand in the x-pack binary.