Skip to content

Build xpack binaries (WIP)#1629

Closed
jalvz wants to merge 3 commits intoelastic:masterfrom
jalvz:build-xpack-binaries
Closed

Build xpack binaries (WIP)#1629
jalvz wants to merge 3 commits intoelastic:masterfrom
jalvz:build-xpack-binaries

Conversation

@jalvz
Copy link
Contributor

@jalvz jalvz commented Dec 6, 2018

This is needed for the first part of central config: incorporate the enroll command in the x-pack binary.

--exclude="dev-tools/jenkins_ci.ps1" \
--exclude="dev-tools/jenkins_intake.sh" \
--exclude="dev-tools/packaging/preference-pane/***" \
--exclude="dev-tools/packaging/packages.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel this is the right way to do it... would it be better to exclude the whole packaging folder altogether, or to find another way to pass the right path?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is a way to avoid having to customize this altogether? For now, I think this needs a trailing slash?

Copy link
Contributor Author

@jalvz jalvz Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in beats the structure is:

`beats`
     `beat1`
     `beatN`
     `x-pack`
         `beat1`
         `beatN`

for us is:

`apm-server`
    `x-pack`
       `apm-server`

so we don't need the .. here: 4530fa0#diff-2a90996ecc944753a4353cab58ca5295L398

... i don't see a way around it, other than changing the structure to match the one from beats which doesn't really make sense:

`some-top-dir`
    `apm-server`
        `x-pack`
           `apm-server`

@jalvz
Copy link
Contributor Author

jalvz commented Dec 6, 2018

@graphaelli would be great if you can have a look, particularly at the 3rd commit.
would be ok to update beats at this time of the year, or would i spoil all the ecs work?

@jalvz
Copy link
Contributor Author

jalvz commented Dec 6, 2018

note: when the time comes, rebase and merge, not squash

@graphaelli
Copy link
Member

A beats update should be fine. Please let me know if make update complains of duplicate fields - it shouldn't but it will mean we need to take some action if it does.

@jalvz jalvz force-pushed the build-xpack-binaries branch from 4530fa0 to 1250fb5 Compare December 7, 2018 12:56
@jalvz jalvz force-pushed the build-xpack-binaries branch from 1250fb5 to 21903cc Compare December 7, 2018 14:26
@jalvz
Copy link
Contributor Author

jalvz commented Dec 12, 2018

redirect #1645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants