This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
added
automation
backport-to-7.x
v1v
commented
Feb 16, 2021
| } | ||
| } | ||
| stage('Google Storage') { | ||
| steps { |
v1v
commented
Feb 16, 2021
| validateDeclarativePipeline '.ci/Jenkinsfile' | ||
| validateDeclarativePipeline '.ci/buildBeatsDockerImages.groovy' | ||
| validateDeclarativePipeline '.ci/buildDockerImages.groovy' | ||
| validateDeclarativePipeline '.ci/chatops.groovy' |
v1v
commented
Feb 16, 2021
Comment on lines
+39
to
+40
| def credentialsVariable = isUnix() ? '${FILE_CREDENTIAL}' : '%FILE_CREDENTIAL%' | ||
| cmd(label: 'authenticate', script: 'gcloud auth activate-service-account --key-file ' + credentialsVariable) |
Member
Author
There was a problem hiding this comment.
Avoid interpolation for any kind of credentials
mergify Bot
pushed a commit
that referenced
this pull request
Feb 16, 2021
(cherry picked from commit 53ac683)
v1v
added a commit
that referenced
this pull request
Mar 18, 2021
* upstream/7.x: Fix the getCause and getCauses for the AbortException (#1041) (#1042) gsutil for windows with python (#1008) (#1009) Report only one DeleteDir step failure (#1006) (#1007) [cosmetic] Replace multiline chars in the GitHub PR comment (#998) (#1003) [cosmetic] add the author (#999) (#1002) chore: use opentelemetry release (#1000) (#1001) Avoid cache gsutils temporary location (#994) (#995) [JCasC] google cloud engine local setup (#979) (#992) Support curl in addition to wget for gsutil (#988) (#989) Support windows for gsutil (#985) (#987) Add googleStorageUploadExt step (#867) (#982) Add releaseNotification step to simplify agent release pipelines (#976) (#981)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support Windows when using the gsutil step
Why is it important?
Beats pipelines use it
Tests
when using the branch itself to test the pipeline -> 0dae25a
Then
jsonfiles were uploaded correctly within the windows context: