Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Add googleStorageUploadExt step#867

Merged
mergify[bot] merged 24 commits intoelastic:masterfrom
v1v:feature/override-google-storage-step
Feb 16, 2021
Merged

Add googleStorageUploadExt step#867
mergify[bot] merged 24 commits intoelastic:masterfrom
v1v:feature/override-google-storage-step

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Dec 1, 2020

What does this PR do?

Support step to interact with the google storage

Why is it important?

Workaround jenkinsci/google-storage-plugin#61

Tests

image

Took 16 seconds to install gsutil and run the copy to the storage, see stage that uploaded the artifacts to google storage here

image

Beats

build

image

image

@ghost
Copy link
Copy Markdown

ghost commented Dec 1, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #867 updated

  • Start Time: 2021-02-16T09:30:49.601+0000

  • Duration: 6 min 47 sec

  • Commit: 2756a39

Test stats 🧪

Test Results
Failed 0
Passed 1046
Skipped 2
Total 1048

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1046
Skipped 2
Total 1048

v1v and others added 19 commits December 1, 2020 17:01
…google-storage-step

* upstream/master: (111 commits)
  Image build pipeline for flaky v2 (#968)
  fix: enable sandbox for pipelines (#967)
  test: taest jobDSL job when them changed (#966)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.185
  feat: Archive only on fail (#952)
  Disable getStageId call (#962)
  docs: side note to setEnvVar step (#957)
  Add mergify bot (#958)
  Mergify: configuration update (#891)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.184
  fix: resize the partition size to 100GB to use all the space (#953)
  fix: GO_VERSION can be undefined (#954)
  chore: bump Go version to 1.15.7 (#951)
  [docs][matrix] explain the new step (#948)
  Show build and test trends as PR comments and GitHub .Status check (#942)
  feat: custom matrix step (#938)
  ...
… feature/override-google-storage-step

* 'master' of github.com:elastic/apm-pipeline-library:
  [chore]: delegate delete to the core (#904)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.186
  chore: refactor jobs in folders (#974)
  Fix broken documentation (#970)
  Add releaseNotification step to simplify agent release pipelines (#976)
  chore(deps-dev): bump junit from 4.13.1 to 4.13.2 (#980)
  Disable/Enable pre-commit skipped tests in the report (#977)
  feat: support parameters for githubPrCheckApproved (#910)
  Automatically merge PRs for the 7.x branch (#971)
  chore: refactor params variables to args (#960)
Comment thread .ci/Jenkinsfile Outdated
@v1v v1v marked this pull request as ready for review February 15, 2021 18:35
@v1v v1v requested a review from a team February 15, 2021 18:35
@v1v v1v self-assigned this Feb 15, 2021
@v1v
Copy link
Copy Markdown
Member Author

v1v commented Feb 16, 2021

elastic/beats#24048 is the consumer :) and it works like a charm

Comment thread vars/gsutil.groovy
Comment on lines +49 to +50
def url = 'https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-319.0.0'
url = "${url}-linux-${is64() ? 'x86_64' : 'x86'}.tar.gz"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ARM supported but only linux 64/32 bits

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it works anyway

image

See build

Comment thread docs/STORAGE.md Outdated
Comment thread docs/STORAGE.md Outdated
Co-authored-by: cachedout <mike.place@elastic.co>
@v1v v1v added backport-to-7.x Automatically backport PRs from master ready-to-merge labels Feb 16, 2021
@mergify mergify Bot merged commit 4bf7ff4 into elastic:master Feb 16, 2021
mergify Bot pushed a commit that referenced this pull request Feb 16, 2021
* Add googleStorageUploadExt step

* chore: for testing purposes

* Fix wrong argument

* Add UTs

* Leftovers for the copy

* Minor refactor to use script

* Add ITs

* Add strip

* Use the right credentials id

* Use the temp bucket

* Use the protocol

* Add JCasC for the Google Storage credentials

* Use another target

* Debugging purposes

* Use another approach

* Use top level options to run in parallel and quietly

* Create stage only for the google storage step

* Warn only since it will fail when executed and use the master branch

* Update .ci/Jenkinsfile

* Apply suggestions from code review

Co-authored-by: cachedout <mike.place@elastic.co>

* Only in master for the time being

Co-authored-by: cachedout <mike.place@elastic.co>
(cherry picked from commit 4bf7ff4)
mergify Bot added a commit that referenced this pull request Feb 16, 2021
* Add googleStorageUploadExt step

* chore: for testing purposes

* Fix wrong argument

* Add UTs

* Leftovers for the copy

* Minor refactor to use script

* Add ITs

* Add strip

* Use the right credentials id

* Use the temp bucket

* Use the protocol

* Add JCasC for the Google Storage credentials

* Use another target

* Debugging purposes

* Use another approach

* Use top level options to run in parallel and quietly

* Create stage only for the google storage step

* Warn only since it will fail when executed and use the master branch

* Update .ci/Jenkinsfile

* Apply suggestions from code review

Co-authored-by: cachedout <mike.place@elastic.co>

* Only in master for the time being

Co-authored-by: cachedout <mike.place@elastic.co>
(cherry picked from commit 4bf7ff4)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@v1v v1v deleted the feature/override-google-storage-step branch February 16, 2021 10:15
v1v added a commit that referenced this pull request Mar 18, 2021
* upstream/7.x:
  Fix the getCause and getCauses for the AbortException (#1041) (#1042)
  gsutil for windows with python (#1008) (#1009)
  Report only one DeleteDir step failure (#1006) (#1007)
  [cosmetic] Replace multiline chars in the GitHub PR comment (#998) (#1003)
  [cosmetic] add the author (#999) (#1002)
  chore: use opentelemetry release (#1000) (#1001)
  Avoid cache gsutils temporary location (#994) (#995)
  [JCasC] google cloud engine local setup (#979) (#992)
  Support curl in addition to wget for gsutil (#988) (#989)
  Support windows for gsutil (#985) (#987)
  Add googleStorageUploadExt step (#867) (#982)
  Add releaseNotification step to simplify agent release pipelines (#976) (#981)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants