This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Work around git init with closure#532
Merged
cachedout merged 1 commit intoelastic:masterfrom May 14, 2020
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kuisathaverat
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When attempting to introduce the Google credentials in #529 a problem was encountered. The credentials file was not present in the built container.
The reason for this is that the
git initthat's run as a part of thegit stepwill wipe out the existing directory. As a result, we need to insert our credentials file after thegit inittakes place but before the container is built.This attempts to do so without being too disruptive to the current architecture by adding a new argument to
buildDockerImagewhich can be a closure which executes after the git step but before the Docker build.Why is it important?
Hopefully resolves the issue with opbot not having the needed credentials file on start.
Related issues
Refs elastic/observability-robots#39