Write credentials for opbot #529
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kuisathaverat
left a comment
kuisathaverat
left a comment
There was a problem hiding this comment.
LGTM if we make a deleteDir at the end of the stage in a post cleanup stage.
@kuisathaverat Could you take a look and see if this change is what you had in mind? |
|
could you add a post with the deleteDir just after the steps{} directive, the thing is to keep only the file for the time it is needed, the stage. It is trying that it is the last stage and the effect will be the same as it is in your implementation but if we add a new stage after yours the credential will live a little more in disk. |
Thanks for the suggestion, @kuisathaverat . Is this what you were suggesting? |
… into feature/stashv2 * 'feature/stashv2' of github.com:v1v/apm-pipeline-library: Write credentials for opbot (#529) Add flake detector to pipeline (#530)
2 participants
What does this PR do?
Pulls in stored credentials file into the workspace just before we build the Docker image.
Why is it important?
In order to deploy the opbeat, we need to have credentials which correctly annotate OAuth requests with the developer profile belonging to the application.
This data is pseudo-sensitive and so it's better if we can keep it in our secret store and write it out just before build time.
Related issues
Refs https://github.com/elastic/observability-robots/issues/39