Skip to content

docs: add angular supported version#963

Merged
vigneshshanmugam merged 3 commits intoelastic:masterfrom
bmorelli25:add-angular-supported-version
Feb 9, 2021
Merged

docs: add angular supported version#963
vigneshshanmugam merged 3 commits intoelastic:masterfrom
bmorelli25:add-angular-supported-version

Conversation

@bmorelli25
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 commented Feb 9, 2021 •
edited
Loading

Adds angular integration supported versions to reduce confusion. Per @vigneshshanmugam, Angular versions < 9 are supported.

Related to #962.

@bmorelli25 bmorelli25 added the docs label Feb 9, 2021
@bmorelli25 bmorelli25 requested a review from a team February 9, 2021 00:17
@bmorelli25 bmorelli25 self-assigned this Feb 9, 2021
bmorelli25
bmorelli25 commented Feb 9, 2021
View reviewed changes
Comment thread docs/angular-integration.asciidoc Outdated
@ghost
Copy link
Copy Markdown

ghost commented Feb 9, 2021 •
edited by ghost
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #963 updated

  • Start Time: 2021-02-09T00:33:36.258+0000

  • Duration: 5 min 6 sec

  • Commit: 9c7c2c9

Trends 🧪

Image of Build Times

Steps errors 1

Expand to view the steps failures

Lint
  • Took 2 min 0 sec . View more details on here
  • Description: HOME=$(pwd) .ci/scripts/lint.sh

Log output

Expand to view the last 100 lines of log output 

[2021-02-09T00:38:13.610Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents):
[2021-02-09T00:38:13.610Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[2021-02-09T00:38:13.610Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/karma/node_modules/fsevents):
[2021-02-09T00:38:13.610Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[2021-02-09T00:38:13.610Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/@wdio/cli/node_modules/fsevents):
[2021-02-09T00:38:13.610Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[2021-02-09T00:38:13.610Z] 
[2021-02-09T00:38:13.610Z] added 2421 packages from 1394 contributors and audited 2502 packages in 92.941s
[2021-02-09T00:38:15.539Z] 
[2021-02-09T00:38:15.539Z] 35 packages are looking for funding
[2021-02-09T00:38:15.539Z]   run `npm fund` for details
[2021-02-09T00:38:15.539Z] 
[2021-02-09T00:38:15.539Z] found 528 vulnerabilities (526 low, 2 high)
[2021-02-09T00:38:15.539Z]   run `npm audit fix` to fix them, or `npm audit` for details
[2021-02-09T00:38:16.117Z] 
[2021-02-09T00:38:16.117Z] > elastic-apm-rum@0.0.0-monorepo lint /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963/src/github.com/elastic/apm-agent-rum-js
[2021-02-09T00:38:16.117Z] > run-p --silent lint:*
[2021-02-09T00:38:16.117Z] 
[2021-02-09T00:38:38.145Z] + [[ -n https://apm-ci.elastic.co/ ]]
[2021-02-09T00:38:38.145Z] ++ npm bin
[2021-02-09T00:38:38.145Z] + export PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-02-09T00:38:38.145Z] + PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-02-09T00:38:38.145Z] ++ pwd
[2021-02-09T00:38:38.145Z] + export HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963/src/github.com/elastic/apm-agent-rum-js
[2021-02-09T00:38:38.145Z] + HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963/src/github.com/elastic/apm-agent-rum-js
[2021-02-09T00:38:38.145Z] + [[ -z 963 ]]
[2021-02-09T00:38:38.145Z] + commitlint --from=origin/master --to=9c7c2c903f0a5131596504f9621ae0f575607ce7
[2021-02-09T00:38:38.145Z] ⧗   input: Update docs/angular-integration.asciidoc
[2021-02-09T00:38:38.145Z] ✖   subject may not be empty [subject-empty]
[2021-02-09T00:38:38.145Z] ✖   type may not be empty [type-empty]
[2021-02-09T00:38:38.145Z] 
[2021-02-09T00:38:38.145Z] ✖   found 2 problems, 0 warnings
[2021-02-09T00:38:38.145Z] ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
[2021-02-09T00:38:38.145Z] 
[2021-02-09T00:38:38.181Z] $ docker stop --time=1 828a0620deb1d1349d2507d7cbf508c8b84633bc94b20d97d5208a3a30bb94bf
[2021-02-09T00:38:39.572Z] $ docker rm -f 828a0620deb1d1349d2507d7cbf508c8b84633bc94b20d97d5208a3a30bb94bf
[2021-02-09T00:38:40.622Z] Stage "Test Pupperteer" skipped due to earlier failure(s)
[2021-02-09T00:38:40.715Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.716Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.716Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.717Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.717Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.717Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.718Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.718Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.719Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.719Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.719Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.720Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.720Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.721Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.722Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.814Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.815Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.816Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.817Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.818Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.819Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.820Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.821Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.821Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.822Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.823Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.823Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.824Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.824Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:40.825Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-09T00:38:41.149Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'
[2021-02-09T00:38:41.150Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'
[2021-02-09T00:38:41.151Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'
[2021-02-09T00:38:41.151Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'
[2021-02-09T00:38:41.152Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'
[2021-02-09T00:38:41.152Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'
[2021-02-09T00:38:41.153Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'
[2021-02-09T00:38:41.153Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'
[2021-02-09T00:38:41.154Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'
[2021-02-09T00:38:41.154Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'
[2021-02-09T00:38:41.155Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'
[2021-02-09T00:38:41.155Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'
[2021-02-09T00:38:41.156Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'
[2021-02-09T00:38:41.156Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'
[2021-02-09T00:38:41.157Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'
[2021-02-09T00:38:41.208Z] Stage "Stack 8.0.0-SNAPSHOT SauceLabs" skipped due to earlier failure(s)
[2021-02-09T00:38:41.240Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-02-09T00:38:41.271Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-02-09T00:38:41.306Z] Stage "Coverage" skipped due to earlier failure(s)
[2021-02-09T00:38:41.338Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-09T00:38:41.353Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-09T00:38:41.385Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-09T00:38:41.417Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-09T00:38:41.464Z] Stage "Opbeans" skipped due to earlier failure(s)
[2021-02-09T00:38:41.726Z] Running on Jenkins in /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-963
[2021-02-09T00:38:41.814Z] [INFO] getVaultSecret: Getting secrets
[2021-02-09T00:38:41.961Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-02-09T00:38:42.637Z] + chmod 755 generate-build-data.sh
[2021-02-09T00:38:42.637Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-963/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-963/runs/3 FAILURE 306120
[2021-02-09T00:38:42.887Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-963/runs/3/steps/?limit=10000 -o steps-info.json
[2021-02-09T00:38:43.438Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-963/runs/3/tests/?status=FAILED -o tests-errors.json
[2021-02-09T00:38:43.438Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-02-09T00:38:44.349Z] Retry 2/3 exited 22, retrying in 2 seconds...

vigneshshanmugam
vigneshshanmugam reviewed Feb 9, 2021
View reviewed changes
Comment thread docs/angular-integration.asciidoc Outdated
vigneshshanmugam
vigneshshanmugam approved these changes Feb 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks brandon, i will fix the lint issue while merging.

@vigneshshanmugam vigneshshanmugam merged commit 7a08020 into elastic:master Feb 9, 2021
@bmorelli25 bmorelli25 deleted the add-angular-supported-version branch February 9, 2021 15:26
v1v added a commit to v1v/apm-agent-rum-js that referenced this pull request Feb 24, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-a…
2a120e2 
…pm-load-testing

* upstream/master:
  ci: use the releaseNotification step (elastic#967)
  docs: add angular supported version (elastic#963)
  chore(rum): add eventtarget to the instrumentation types (elastic#920)
  ci: remove travis references (elastic#960)
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
@bmorelli25
docs: add angular supported version (elastic#963)
be10248 
* docs: angular supported version

* docs: change to less than 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@bmorelli25 bmorelli25

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmorelli25 @vigneshshanmugam