Skip to content

chore(rum): add eventtarget to the instrumentation types#920

Merged
vigneshshanmugam merged 2 commits intoelastic:masterfrom
ksivamuthu:patch-1
Feb 8, 2021
Merged

chore(rum): add eventtarget to the instrumentation types#920
vigneshshanmugam merged 2 commits intoelastic:masterfrom
ksivamuthu:patch-1

Conversation

@ksivamuthu
Copy link
Copy Markdown
Contributor

@ksivamuthu ksivamuthu commented Oct 13, 2020

Add eventtarget to the instrumentation types.

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented Oct 13, 2020 •
edited
Loading

💚 CLA has been signed

@ghost
Copy link
Copy Markdown

ghost commented Oct 13, 2020 •
edited by ghost
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

    • Start Time: 2021-02-07T01:46:17.725+0000

  • Duration: 6 min 55 sec

  • Commit: 6805e3b

Steps errors 1

Expand to view the steps failures

Lint
  • Took 2 min 54 sec . View more details on here
  • Description: HOME=$(pwd) .ci/scripts/lint.sh

Log output

Expand to view the last 100 lines of log output 

[2021-02-07T01:51:47.416Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[2021-02-07T01:51:47.416Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/@wdio/cli/node_modules/fsevents):
[2021-02-07T01:51:47.416Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[2021-02-07T01:51:47.416Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: puppeteer-firefox@0.5.0 (node_modules/puppeteer-firefox):
[2021-02-07T01:51:47.416Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: puppeteer-firefox@0.5.0 install: `node install.js`
[2021-02-07T01:51:47.416Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1
[2021-02-07T01:51:47.416Z] 
[2021-02-07T01:51:47.416Z] added 2417 packages from 1394 contributors and audited 2502 packages in 91.98s
[2021-02-07T01:51:49.334Z] 
[2021-02-07T01:51:49.334Z] 35 packages are looking for funding
[2021-02-07T01:51:49.334Z]   run `npm fund` for details
[2021-02-07T01:51:49.334Z] 
[2021-02-07T01:51:49.334Z] found 528 vulnerabilities (526 low, 2 high)
[2021-02-07T01:51:49.334Z]   run `npm audit fix` to fix them, or `npm audit` for details
[2021-02-07T01:51:49.596Z] 
[2021-02-07T01:51:49.596Z] > elastic-apm-rum@0.0.0-monorepo lint /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920/src/github.com/elastic/apm-agent-rum-js
[2021-02-07T01:51:49.596Z] > run-p --silent lint:*
[2021-02-07T01:51:49.596Z] 
[2021-02-07T01:52:07.725Z] + [[ -n https://apm-ci.elastic.co/ ]]
[2021-02-07T01:52:07.725Z] ++ npm bin
[2021-02-07T01:52:07.725Z] + export PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-02-07T01:52:07.725Z] + PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-02-07T01:52:07.725Z] ++ pwd
[2021-02-07T01:52:07.725Z] + export HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920/src/github.com/elastic/apm-agent-rum-js
[2021-02-07T01:52:07.725Z] + HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920/src/github.com/elastic/apm-agent-rum-js
[2021-02-07T01:52:07.725Z] + [[ -z 920 ]]
[2021-02-07T01:52:07.725Z] + commitlint --from=origin/master --to=6805e3b0cea04bbc550fd463a04666f60094af4d
[2021-02-07T01:52:07.725Z] ⧗   input: Add eventtarget to the Instrumentation Types
[2021-02-07T01:52:07.725Z] ✖   subject may not be empty [subject-empty]
[2021-02-07T01:52:07.725Z] ✖   type may not be empty [type-empty]
[2021-02-07T01:52:07.725Z] 
[2021-02-07T01:52:07.725Z] ✖   found 2 problems, 0 warnings
[2021-02-07T01:52:07.725Z] ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
[2021-02-07T01:52:07.725Z] 
[2021-02-07T01:52:05.610Z] $ docker stop --time=1 46a53b47ccc7e0b3792bea3fb7d43162b04a02ab9f5d73ca3d786c95f6de98fe
[2021-02-07T01:52:08.273Z] $ docker rm -f 46a53b47ccc7e0b3792bea3fb7d43162b04a02ab9f5d73ca3d786c95f6de98fe
[2021-02-07T01:52:11.442Z] Stage "Test Pupperteer" skipped due to earlier failure(s)
[2021-02-07T01:52:11.552Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.553Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.554Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.554Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.555Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.556Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.556Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.557Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.557Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.558Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.558Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.559Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.559Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.560Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.561Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.647Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.647Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.648Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.649Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.650Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.650Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.651Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.651Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.652Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.653Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.653Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.654Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.655Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.655Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.656Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-02-07T01:52:11.947Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'
[2021-02-07T01:52:11.948Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'
[2021-02-07T01:52:11.948Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'
[2021-02-07T01:52:11.949Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'
[2021-02-07T01:52:11.950Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'
[2021-02-07T01:52:11.950Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'
[2021-02-07T01:52:11.951Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'
[2021-02-07T01:52:11.951Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'
[2021-02-07T01:52:11.952Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'
[2021-02-07T01:52:11.952Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'
[2021-02-07T01:52:11.953Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'
[2021-02-07T01:52:11.953Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'
[2021-02-07T01:52:11.954Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'
[2021-02-07T01:52:11.955Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'
[2021-02-07T01:52:11.956Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'
[2021-02-07T01:52:12.006Z] Stage "Stack 8.0.0-SNAPSHOT SauceLabs" skipped due to earlier failure(s)
[2021-02-07T01:52:12.038Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-02-07T01:52:12.071Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-02-07T01:52:12.105Z] Stage "Coverage" skipped due to earlier failure(s)
[2021-02-07T01:52:12.137Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-07T01:52:12.153Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-07T01:52:12.186Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-07T01:52:12.218Z] Stage "Release" skipped due to earlier failure(s)
[2021-02-07T01:52:12.266Z] Stage "Opbeans" skipped due to earlier failure(s)
[2021-02-07T01:52:12.542Z] Running on Jenkins in /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-920
[2021-02-07T01:52:12.633Z] [INFO] getVaultSecret: Getting secrets
[2021-02-07T01:52:12.780Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-02-07T01:52:13.439Z] + chmod 755 generate-build-data.sh
[2021-02-07T01:52:13.440Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-920/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-920/runs/16 FAILURE 355454
[2021-02-07T01:52:13.690Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-920/runs/16/steps/?limit=10000 -o steps-info.json
[2021-02-07T01:52:14.241Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-920/runs/16/tests/?status=FAILED -o tests-errors.json
[2021-02-07T01:52:14.241Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-02-07T01:52:15.152Z] Retry 2/3 exited 22, retrying in 2 seconds...

@vigneshshanmugam vigneshshanmugam changed the title Add eventtarget to the Instrumentation Types chore(rum): add eventtarget to the instrumentation types Oct 30, 2020
vigneshshanmugam
vigneshshanmugam approved these changes Oct 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ksivamuthu

hmdhk
hmdhk suggested changes Nov 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ksivamuthu !
would you please sign the CLA?
Also the lint task is failing, I've added a suggestion to fix that.

Comment thread packages/rum/src/index.d.ts Outdated
vigneshshanmugam
vigneshshanmugam approved these changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Will fix the commit message issue while merging.

@vigneshshanmugam vigneshshanmugam merged commit c28b72b into elastic:master Feb 8, 2021
v1v added a commit to v1v/apm-agent-rum-js that referenced this pull request Feb 24, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-a…
2a120e2 
…pm-load-testing

* upstream/master:
  ci: use the releaseNotification step (elastic#967)
  docs: add angular supported version (elastic#963)
  chore(rum): add eventtarget to the instrumentation types (elastic#920)
  ci: remove travis references (elastic#960)
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
@ksivamuthu
chore(rum): add eventtarget to the instrumentation types (elastic#920)
d36b7cc 
chore(rum): add eventtarget to the instrumentation types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

+1 more reviewer

@hmdhk hmdhk hmdhk requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ksivamuthu @vigneshshanmugam @hmdhk @jahtalab