Skip to content

[2.x] docs: update moved secret token link#430

Merged
bmorelli25 merged 1 commit intoelastic:2.xfrom
bmorelli25:moved-link-2.x
Sep 19, 2019
Merged

[2.x] docs: update moved secret token link#430
bmorelli25 merged 1 commit intoelastic:2.xfrom
bmorelli25:moved-link-2.x

Conversation

@bmorelli25
Copy link
Member

For elastic/apm-server#2728. Must be merged at the same time.

# Conflicts:
#	docs/sourcemap.asciidoc
@vigneshshanmugam
Copy link
Member

Do we need to backport docs changes to previous versions?

@bmorelli25
Copy link
Member Author

bmorelli25 commented Sep 19, 2019

@vigneshshanmugam In this case yes. We've restructured the APM Server documentation drastically (which we typically don't do) and it caused the destination of the secret token link to move pages (elastic/apm-server#2728 (comment)). I have to fix the link as far back as it exists in the RUM documentation.

You are correct that typically this wouldn't be needed as I don't move links around that often.

ci/docs failure is expected as elastic/apm-server#2728 hasn't been merged yet.

@vigneshshanmugam
Copy link
Member

@bmorelli25 Thanks for the detailed info 🙂. Do you want to wait for the serer PR to get merged before merging this change?

The changes looks good to me.

@bmorelli25
Copy link
Member Author

It's a weird one because if I merge any of these without the others, it will break the main doc build. I'm going to wait for ci to be green (except for docs) and merge all 5 PRs at the same time.

@vigneshshanmugam
Copy link
Member

Haha, you need a merge bot now 😄

@bmorelli25 bmorelli25 merged commit c3dde50 into elastic:2.x Sep 19, 2019
@bmorelli25 bmorelli25 deleted the moved-link-2.x branch September 19, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants