Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if bundle is empty before creating base field definition #502

Merged
merged 1 commit into from
Jan 3, 2025
Merged

check if bundle is empty before creating base field definition #502

merged 1 commit into from
Jan 3, 2025

Conversation

jackrabbithanna
Copy link
Collaborator

Overview

Error reported in https://www.drupal.org/project/civicrm_entity/issues/3475302
in combination with #497

Drupal\Core\Field\FieldException: Attempt to create a base field bundle override of field id without a bundle in Drupal\Core\Field\Entity\BaseFieldOverride->__construct() (line 110 of /var/www/drupal/web/core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php).

@civibot civibot bot added the 4.0.x label Sep 20, 2024
@KarinG
Copy link
Contributor

KarinG commented Oct 4, 2024

Not sure how this passed?

file:///Users/sysadmin/Downloads/phpunit_browser_output%20(25)/Drupal_Tests_civicrm_entity_FunctionalJavascript_Views_ActivityFullcalendarViewTest-4-95073011.html is not showing any Calendar display.

I suspect it's the D11 run.

file:///Users/sysadmin/Downloads/phpunit_browser_output%20(25)/Drupal_Tests_civicrm_entity_FunctionalJavascript_Views_ActivityFullcalendarViewTest-4-72026026.html looks good:

image

@jackrabbithanna
Copy link
Collaborator Author

Does this PR break fullcalendar_view displays for you?

@KarinG
Copy link
Contributor

KarinG commented Oct 4, 2024

Download the assets produced by the test and then compare the ActivityFullcalendarViewTest-4 html files. Two look fine and one is blank (no calendar is displayed). Pretty sure it's the D11 one -> to split the assets up by Drupal x CiviCRM combination we recently did that for WFC.

@jackrabbithanna
Copy link
Collaborator Author

In manual testing on Drupal 11.1, a full calendar View showing events, I see events on the calendar. Merging #502

@jackrabbithanna jackrabbithanna merged commit 8c4ad26 into eileenmcnaughton:4.0.x Jan 3, 2025
3 checks passed
puresyntax71 pushed a commit to puresyntax71/civicrm_entity that referenced this pull request Jan 9, 2025
@jackrabbithanna @puresyntax71
check if bundle is empty before creating base field definition (eilee…
0e9b470 
…nmcnaughton#502)
puresyntax71 added a commit to puresyntax71/civicrm_entity that referenced this pull request Jan 9, 2025
@puresyntax71
Merge remote-tracking branch 'origin/4.0.x' into 4.0.x-github-actions
fef631d 
* origin/4.0.x: (65 commits)
  Fix unknown entity type with multilingual (eileenmcnaughton#497)
  check if bundle is empty before creating base field definition (eileenmcnaughton#502)
  Allow having a different civicrm_entity entity id and table. (eileenmcnaughton#501)
  Update Conditions to support PHP Attributes (eileenmcnaughton#498)
  require Drupal 10.3 as minimum version (eileenmcnaughton#503)
  D11 Tests (eileenmcnaughton#499)
  update port chromedriver (eileenmcnaughton#500)
  Add check to ensure CiviCRM container is booted before invoking hooks (eileenmcnaughton#492)
  Replace deprecation for search_api. (eileenmcnaughton#455)
  Support for basefield overrides (eileenmcnaughton#496)
  update tests, 10.3 official, and 5.75 (eileenmcnaughton#490)
  check for metatag_computed field, for Drupal entity based saves with Metatag 2.0 (eileenmcnaughton#489)
  use LoggerChannelFactoryInterface instead of default service (eileenmcnaughton#488)
  update tests for 10.3 and 11 (eileenmcnaughton#484)
  fix edge case updating base field definition for bundles (eileenmcnaughton#487)
  Add patch from https://www.drupal.org/project/civicrm_entity/issues/3447309. (eileenmcnaughton#486)
  Fix metatag not loading. (eileenmcnaughton#481)
  update settings form for D11 compatibility (eileenmcnaughton#485)
  adding logger parameter to ModulerInstaller service (eileenmcnaughton#483)
  update composer.json for Drupal 11 (eileenmcnaughton#482)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackrabbithanna @KarinG