Update Conditions to support PHP Attributes #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In Drupal 10.2 / 10.3 various plugin types now support PHP Attributes, and annotations will be deprecated and in Drupal 12 will not be supported. For those people choosing to use newer versions, this PR is available to use as a patch. |
puresyntax71
pushed a commit
to puresyntax71/civicrm_entity
that referenced
this pull request
Jan 9, 2025
Co-authored-by: Rafał Dziubak <[email protected]>
puresyntax71
added a commit
to puresyntax71/civicrm_entity
that referenced
this pull request
Jan 9, 2025
* origin/4.0.x: (65 commits) Fix unknown entity type with multilingual (eileenmcnaughton#497) check if bundle is empty before creating base field definition (eileenmcnaughton#502) Allow having a different civicrm_entity entity id and table. (eileenmcnaughton#501) Update Conditions to support PHP Attributes (eileenmcnaughton#498) require Drupal 10.3 as minimum version (eileenmcnaughton#503) D11 Tests (eileenmcnaughton#499) update port chromedriver (eileenmcnaughton#500) Add check to ensure CiviCRM container is booted before invoking hooks (eileenmcnaughton#492) Replace deprecation for search_api. (eileenmcnaughton#455) Support for basefield overrides (eileenmcnaughton#496) update tests, 10.3 official, and 5.75 (eileenmcnaughton#490) check for metatag_computed field, for Drupal entity based saves with Metatag 2.0 (eileenmcnaughton#489) use LoggerChannelFactoryInterface instead of default service (eileenmcnaughton#488) update tests for 10.3 and 11 (eileenmcnaughton#484) fix edge case updating base field definition for bundles (eileenmcnaughton#487) Add patch from https://www.drupal.org/project/civicrm_entity/issues/3447309. (eileenmcnaughton#486) Fix metatag not loading. (eileenmcnaughton#481) update settings form for D11 compatibility (eileenmcnaughton#485) adding logger parameter to ModulerInstaller service (eileenmcnaughton#483) update composer.json for Drupal 11 (eileenmcnaughton#482) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the custom rules conditions to support PHP attributes for plugin discovery. The change aligns the code with Drupal’s latest standards, preparing it for future upgrades.
Before
The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
After
What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
Technical Details
If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary
Comments
The update does not remove any annotations, it only adds PHP attributes.
Release notes snippet
The notes to be added on the release