Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conditions to support PHP Attributes #498

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

rafaldziubak
Copy link
Contributor

Overview

This pull request updates the custom rules conditions to support PHP attributes for plugin discovery. The change aligns the code with Drupal’s latest standards, preparing it for future upgrades.

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

The update does not remove any annotations, it only adds PHP attributes.

Release notes snippet

The notes to be added on the release

@civibot civibot bot added the 4.0.x label Aug 14, 2024
@jackrabbithanna
Copy link
Collaborator

In Drupal 10.2 / 10.3 various plugin types now support PHP Attributes, and annotations will be deprecated and in Drupal 12 will not be supported.
In Drupal 10.3, it broke Rules module and required a new version (4.0.x) and plugins supporting PHP Attributes.
The plan for this PR will be to have it as an option for those who make the switch to Rules 4.x
We'll merge this code for sure by the end of the year, and will consider making CiviCRM Entity require Drupal 10.3, but only after a few months after 10.2 has gone unsupported (Dec 2024)

For those people choosing to use newer versions, this PR is available to use as a patch.

@jackrabbithanna jackrabbithanna marked this pull request as ready for review October 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants