dotnetcore

[Dirtypaws]

#2 Rebuilt the solution like Nancy to allow linked code files across xproj and csproj. Had some merge conflicts with the nuget updates, but, they should be working correctly now.

[efaruk]

Well done Matt, you are just amazing, I'm really happy to work with you...

[Dirtypaws]

I should also mention - one other thing I did in there. Because my local Redis instance is at a different IP. I abstracted that out into two helper files in the Demo and the tests. Because the two frameworks have different conventions for using config files they each maintain their own helper files to read the config respective to the environment.

Example:
In the .NET framework demo project there's a Helper/SettingsHelper.cs to get the Redis instance:

public static string Redis => ConfigurationManager.AppSettings["redis"]

While the same file in the dotnetcore project looks like this:

        static string _env;
        static string Env => _env ?? (_env = Environment.GetEnvironmentVariable("env"));

        static bool IsDevelopment => Env == "Dev";

        public static IConfigurationRoot Configuration
        {
            get
            {
                var builder = new ConfigurationBuilder()
                    .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
                    .AddJsonFile($"appsettings.{Env}.json", optional: true);

                if (IsDevelopment) builder.AddUserSecrets();

                builder.AddEnvironmentVariables();
                return builder.Build();
            }
        }

        public static string Redis => Configuration["redis"];

That's probably something that it should do anyway - and the nuget can provide it's own configuration settings file when installed - like NLog. So essentially, the Framework solutions are in the .Build folders and maintain their csproj file as well as any framework specific files and their packages.config. the non '.build' folders house the xproj files and their project.json files.

[efaruk]

Thank you very much Matt...

[efaruk]

Also i'm trying to create basic flows and drawings right now...

[Dirtypaws]

Mind if I merge this pull request? It'll help me from dealing with conflicts to nuget updates and such.

[efaruk]

Of course keep going...

On Thu, Oct 6, 2016, 21:38 Matt Krizanac [email protected] wrote:

Mind if I merge this pull request? It'll help me from dealing with
conflicts to nuget updates and such.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#8 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACtflbm9fg4bb6f6LtjWx87hHd8OiDZOks5qxUAfgaJpZM4KPK4r
.

[efaruk]

I was looked forward for that one ;)

On Thu, Oct 6, 2016, 21:47 Matt Krizanac [email protected] wrote:

Merged #8 #8.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#8 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACtflZzp8u0m5Bp4YwQ4S1tKXCzPoEhPks5qxUIvgaJpZM4KPK4r
.