-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnetcore #2
Comments
Would you like to join us and implement/maintain dotnet core compatibility? I think we could maintain in the same repository with different sln... |
I think youre right, we'll use the same repo. I'll set up a new solution with projects using a .core suffix. So it would be Yakari.Core and Yakari.Core.Redis etc... |
Yes absolutely and we can link original *.cs files to core projects. If you need help you can check https://github.com/NancyFx/Nancy solution/project structure. |
If you want to create Yakari and Yakari.Core root folders for solution level seperation please let me know... |
dotnetcore projects don't support file linking like that yet. I think there's a way to do it through the xproj with manual editing - so I can look into that. |
We may also support mono!? How about that? The code base should be compatible with both dotnetcore and mono... |
I think NancyFx team handling this very well: (Without linking of course as you mentioned) https://github.com/NancyFx/Nancy If you could check Nancy.sln Nancy.Next.sln it's showing the way... |
Ahhh - I see. They used the dotnet core xproj's to house all of the files then they created csproj's to link the csproj files to link the files from the xproj. Interesting approach - I'll see what it takes to do that. I'm not too familiar with Mono conversions - but - I imagine if the code works for dotnetcore it'll work for mono. The biggest issue I would see there is the libraries supporting mono. But, again - if they work with core they should work with Mono. |
Xbuild and msbuild almost same... On Wed, Oct 5, 2016, 19:34 Matt Krizanac [email protected] wrote:
|
I want to give you AppVayor access case of if any further requirement and there is no private message feature at github, how can i learn your e-mail adress? |
I sent it to you on Twitter - along with a request to the slack channel |
I think github faster then twitter, your comment mail arrived but no Twitter message ;) |
My twitter profile is https://twitter.com/farukpehlivanli |
I have given Admin access to AppVeyor... |
Hi Matt, I'm having issues building Yakari.Core.sln on Ubuntu 16.04: (Ubuntu Mate 16.04) Error:null: Can not find runtime target for framework '.NETCoreApp,Version=v1.0' compatible with one of the target runtimes: 'ubuntu.16.04-x64'. Possible causes: Note: I have tried with following project.json additions but i'm getting same output "runtimes": { Is there any guidance or reference for me ? Ref: Is this related https://github.com/dotnet/cli/issues/3657 ? |
Nope, it's not that. It's just a thing that happens when a nuget package updates through the tool. It's supposed to keep the body of the package, but, it just replaces it with a version number. Check my last two commits |
Do we have any works to do for dotnetcore or could we close the issue? |
I think we can close, but, i think we need to discuss a settings/config On Oct 7, 2016 8:55 AM, "E. Faruk Pehlivanlı" [email protected]
|
I have created new issue #9 for that... |
I think a library like this would be extremely helpful on dotnetcore, I have a host of dotnetcore applications running in docker containers and the caching mechanisms would really shine with a shared redis container.
I forked and migrated a lot of the code to dotnetcore already. Most of the changes were in the unit test and demo project. There were some timer changes - and I'll be honest, I didn't really look into the code too closely to see how the timers were being used. Just migrated them to the System.Threading.Timers namespace, as the System.Timer isn't available in dotnetcore. But, all the tests pass - so long as the tests were covering their usage, should be good to go.
Dirtypaws@d7d3f79
Not sure if you want to put this on a separate repository or just a dotnetcore branch. I can set up a PR if you'd like. If not, I wouldn't mind setting this up as a new repo and maintaining it myself.
The text was updated successfully, but these errors were encountered: