WIP (DO NOT MERGE) attempt to identify and solve of strictNullChecks errors (many)#475
Closed
danielweck wants to merge 50 commits intodevelopfrom
Closed
WIP (DO NOT MERGE) attempt to identify and solve of strictNullChecks errors (many)#475danielweck wants to merge 50 commits intodevelopfrom
danielweck wants to merge 50 commits intodevelopfrom
Conversation
… etc. (activated TSLint project types)
"strictNullChecks": true, "strictPropertyInitialization": true
… formatting) errors
danielweck
changed the title
Member
Author
|
Note that TypeScript 3.6 will provide strongly-typed iterators and generators, which means that the returned values of Redux-Saga |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code changes in this PR are much less trivial than #404
(because code logic is affected, due to
nullandundefinedhaving very different meaning and applications)In my analysis of the current codebase, there are many instances of unhandled null/undefined values, including promises that should reject instead of resolving, etc.