Fixes #626 : multiple import don't stop if an import fail#680
Merged
danielweck merged 3 commits intoedrlab:developfrom Sep 6, 2019
Merged
Fixes #626 : multiple import don't stop if an import fail#680danielweck merged 3 commits intoedrlab:developfrom
danielweck merged 3 commits intoedrlab:developfrom
Conversation
danielweck
reviewed
Sep 5, 2019
danielweck
reviewed
Sep 5, 2019
danielweck
requested changes
Sep 5, 2019
Member
danielweck
left a comment
danielweck
left a comment
There was a problem hiding this comment.
Works great, thanks!
Can we please just check null/undefined promise values returned by the import function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.