Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Bundled versions" section to the readme #236

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

scy
Copy link
Contributor

@scy scy commented Apr 13, 2024

Based on my research in #234 (comment). This allows people to understand at a glance whether they need to install the plugin at all.

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall the clarification looks good. Just one minor comment.

* Vim 9.0.1799 and above comes bundled with [a version of this plugin][].
* Neovim 0.9 and above comes with [its own Lua-based implementation][].

Both support the usual [properties][], including `max_line_length`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this paragraph needed? I feel this one causes more confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there to assure people that the bundled implementations are not a "light" version that's missing any features. For me personally this was one of the main questions that were on my mind when deciding whether to use the bundled version or install this plugin. Therefore I think that it makes sense to have at least something like this sentence. But if you have any suggestions on how to rephrase it, go ahead! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no worry! I'll make changes

@xuhdev xuhdev merged commit 93b4e77 into editorconfig:master Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants