Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this plugin become obsolete with Neovim v10? #234

Closed
fernandocanizo opened this issue Jan 12, 2024 · 7 comments
Closed

Will this plugin become obsolete with Neovim v10? #234

fernandocanizo opened this issue Jan 12, 2024 · 7 comments

Comments

@fernandocanizo
Copy link

Hello, this is a question, not a bug.

Will editorconfig-vim become obsolete for users of Neovim now that version 10 will have EditorConfig recognition and application included?

@xuhdev
Copy link
Member

xuhdev commented Jan 14, 2024

I don't think you need to install this plugin for Neovim. However, this plugin is still useful for Vim and is not considered obsolete. After all, this is a "Vim" plugin :)

@scy
Copy link
Contributor

scy commented Feb 17, 2024

Would it maybe make sense to add an overview in the readme that explains which versions of Vim and Neovim need this plugin and which don't? And also (if that's a thing) which EditorConfig features might be unavailable when using the built-in support versus when using the plugin?

@scy
Copy link
Contributor

scy commented Feb 17, 2024

A version of this plugin (e014708 from 2023-08-07) comes bundled with Vim since 9.0.1799, see vim/vim#12902.

A Lua EditorConfig implementation comes bundled with Neovim since 0.9, see neovim/neovim@ab9a2c4. It supports all properties currently in the wiki, including max_line_length.

@xuhdev
Copy link
Member

xuhdev commented Apr 11, 2024

@scy Please check out #223 (comment) . While Vim now includes this plugin, the development still happens in this repo.

@scy
Copy link
Contributor

scy commented Apr 13, 2024

@xuhdev Yes, I didn't disagree with that. My suggestion was to add a short section to the readme that explains to people who arrive at this repo whether they need to install it or whether their version of (Neo)Vim already comes with it.

scy added a commit to scy/editorconfig-vim that referenced this issue Apr 13, 2024
@scy
Copy link
Contributor

scy commented Apr 13, 2024

@xuhdev I've created #236 to show you what I mean.

xuhdev pushed a commit that referenced this issue Apr 13, 2024
@xuhdev
Copy link
Member

xuhdev commented Apr 13, 2024

Now clarified in README

@xuhdev xuhdev closed this as completed Apr 13, 2024
fernandocanizo added a commit to fernandocanizo/flc-nvim-config that referenced this issue Jul 1, 2024
Parsing and interpretation of `.editorconfig` files comes bundled into
vim and nvim according to this:
editorconfig/editorconfig-vim#234 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants