Skip to content

refactor: route media subprocesses through adapter - #46

Merged
edhor1608 merged 1 commit into
mainfrom
repo-refresh-media-process-adapter
May 2, 2026
Merged

edhor1608 merged 1 commit into
mainfrom
repo-refresh-media-process-adapter

Conversation

@edhor1608

@edhor1608 edhor1608 commented May 1, 2026 •

Copy link
Copy Markdown
Owner

Route ffmpeg and ffprobe calls through a shared adapter in media domain

Introduces media_process.ts with runFfmpeg and runFfprobe wrappers that delegate to an internal runMediaProcess utility, which calls Bun.spawnSync and returns typed string results for exitCode, stdout, and stderr.

Replaces direct Bun.spawnSync calls in export_image.ts, export_video.ts, media_inspector.ts, and objective_metrics.ts with calls to the new adapters, eliminating per-call Buffer-to-string conversions.

Macroscope summarized de61e94.

@coderabbitai

coderabbitai Bot commented May 1, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@edhor1608 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 53 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: de2d6766-4493-4ba9-b7a8-f5950777bb72

📥 Commits

Reviewing files that changed from the base of the PR and between 203fddd and de61e94.

📒 Files selected for processing (6)
  • docs/repo_refresh_audit.md
  • src/domain/export_image.ts
  • src/domain/export_video.ts
  • src/domain/media_inspector.ts
  • src/domain/media_process.ts
  • src/domain/objective_metrics.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch repo-refresh-media-process-adapter
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch repo-refresh-media-process-adapter

Review rate limit: 0/5 reviews remaining, refill in 1 minute and 53 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@edhor1608
edhor1608 force-pushed the repo-refresh-shared-cli-args branch from 3a5fa85 to ec7253f Compare May 2, 2026 19:03
@edhor1608
edhor1608 force-pushed the repo-refresh-media-process-adapter branch from 5e758f0 to 9603e6c Compare May 2, 2026 19:03
@edhor1608
edhor1608 marked this pull request as ready for review May 2, 2026 19:03
@edhor1608
edhor1608 changed the base branch from repo-refresh-shared-cli-args to main May 2, 2026 21:20
@edhor1608
edhor1608 force-pushed the repo-refresh-media-process-adapter branch from 9603e6c to 1dba0d0 Compare May 2, 2026 21:23
@graphite-app
graphite-app Bot changed the base branch from main to repo-refresh-shared-cli-args May 2, 2026 21:24
@edhor1608
edhor1608 force-pushed the repo-refresh-media-process-adapter branch from 1dba0d0 to ce15db4 Compare May 2, 2026 21:25
@edhor1608
edhor1608 changed the base branch from repo-refresh-shared-cli-args to graphite-base/46 May 2, 2026 21:32
@edhor1608
edhor1608 force-pushed the repo-refresh-media-process-adapter branch from ce15db4 to de61e94 Compare May 2, 2026 21:32
@edhor1608
edhor1608 changed the base branch from graphite-base/46 to main May 2, 2026 21:32
@edhor1608
edhor1608 merged commit f6c2e9d into main May 2, 2026
3 checks passed
@edhor1608
edhor1608 deleted the repo-refresh-media-process-adapter branch May 15, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant