[frontend] Add Base Images #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4262194384
💛 - Coveralls |
Pavinati
requested changes
Feb 22, 2023
npm run relay:generate-schema npm run format Signed-off-by: Sergey Zakhlypa <[email protected]>
- rename `BaseImage` type to `BaseImageInfo` to respect new schema - add stubbed data to mock Relay's responses for BaseImage queries Signed-off-by: Sergey Zakhlypa <[email protected]>
Add the BaseImagesTable React component Signed-off-by: Sergey Zakhlypa <[email protected]>
Fetch BaseImageCollection's BaseImages and show them on BaseImageCollection page Signed-off-by: Sergey Zakhlypa <[email protected]>
npm install --save semver @types/semver Signed-off-by: Sergey Zakhlypa <[email protected]>
Without React's batched updates re-render order is not guaranteed and a child component can update before the parent. This way sometimes react-relay hooks like `useFragment` can return null even for non-nullable field(s). Batching with `unstable_batchedUpdates` is a valid [work around](facebook/react#16387 (comment)), also starting from 18 version React uses [automatic batching](reactwg/react-18#21) but continue to support `unstable_batchedUpdates`. Signed-off-by: Sergey Zakhlypa <[email protected]>
Add a page with a form to create Base Image Signed-off-by: Sergey Zakhlypa <[email protected]>
Add a page with a form to view and edit Base Image Signed-off-by: Sergey Zakhlypa <[email protected]>
npm run i18n:extract Signed-off-by: Sergey Zakhlypa <[email protected]>
- update base images changes - add periods at the end of changes where they're omitted to fix [inconsistency](olivierlacan/keep-a-changelog#450) Signed-off-by: Sergey Zakhlypa <[email protected]>
szakhlypa
force-pushed
the
frontend-base-images
branch
from
e623ffa
to
8403855
Compare
Pavinati
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #240
Adds forms and logic to create, update and delete Base Images.
Create Base Image:
2023-02-10.09-20-28.mp4
Update and delete Base Image:
2023-02-10.09-23-20.mp4