Add Base Images #240
Merged
Add Base Images #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbino
force-pushed
the
base-images
branch
2 times, most recently
from
2b1c9da
to
d120193
Compare
Pull Request Test Coverage Report for Build 02a494719b416a2c593a6c9048f2ba8eb2ec5a22-PR-240
💛 - Coveralls |
rbino
force-pushed
the
base-images
branch
3 times, most recently
from
50db31f
to
1aacf42
Compare
rbino
requested review from
davidebriani,
bettio,
Pavinati and
szakhlypa
and removed request for
bettio
davidebriani
requested changes
Jan 23, 2023
szakhlypa
requested changes
Jan 23, 2023
rbino
force-pushed
the
base-images
branch
4 times, most recently
from
579581a
to
42bba4f
Compare
szakhlypa
requested changes
Jan 27, 2023
davidebriani
requested changes
Jan 30, 2023
davidebriani
approved these changes
Jan 30, 2023
Generated with: mix phx.gen.context BaseImages BaseImage base_images \ version:string:unique release_display_name:map description:map \ starting_version_requirement:string \ base_image_collection_id:references:base_image_collections \ tenant_id:references:tenants Copyright headers and formatting added afterwards Signed-off-by: Riccardo Binetti <[email protected]>
Generate unique handle, names and part numbers. This is helpful when using them to generate associations. Signed-off-by: Riccardo Binetti <[email protected]>
It needs to be used in multiple changesets Signed-off-by: Riccardo Binetti <[email protected]>
In the context: - Add localization to description and display name - Change get_base_image!/1 to fetch_base_image/1 - Disallow updating version on update - Preload the associations In the migration: - Fix indexes including the tenant_id - Add non-nullability where relevant Also adapt tests, adding helpers to reduce noise Signed-off-by: Riccardo Binetti <[email protected]>
Store the file in a bucket and save the URL. Add relevant mocks to tests. Signed-off-by: Riccardo Binetti <[email protected]>
Preload it in the default base image collection preloads Signed-off-by: Riccardo Binetti <[email protected]>
List images for a specific base image collection Signed-off-by: Riccardo Binetti <[email protected]>
Make room for the BaseImage object, representing an actual uploaded base image Signed-off-by: Riccardo Binetti <[email protected]>
Allow retrieving a baseImage given its id. Add tests for the query. Signed-off-by: Riccardo Binetti <[email protected]>
Allow retrieving the list of base images in a base image collection Signed-off-by: Riccardo Binetti <[email protected]>
Allow uploading a base image to a base image collection Signed-off-by: Riccardo Binetti <[email protected]>
Allow updating an existing BaseImage Signed-off-by: Riccardo Binetti <[email protected]>
Allow removing an existing base image. Update CHANGELOG since Base Image support is now complete. Signed-off-by: Riccardo Binetti <[email protected]>
szakhlypa
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow uploading a Base Image to a Base Image Collection and doing all CRUD operations on it