Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use options instead of definitions for header override #871

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

pbdot
Copy link
Collaborator

@pbdot pbdot commented Jan 30, 2025

@LoboEire / @dashodanger This may fix the header issue, not sure as it isn't reproducing locally or on the EC CI

@pbdot pbdot merged commit 32aaefd into master Jan 30, 2025
5 checks passed
@pbdot pbdot deleted the ec-fix-msvc branch January 30, 2025 20:30
@LoboEire
Copy link
Collaborator

I'll try it on a PC that has VS Community and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants