Fix various issues identified by cppcheck #865
Merged
+504
−502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass/test of using cppcheck for some static analysis to help clean up the code. I've fixed all of the most severe ("Error") findings present within source_files, with the exception of one instance in epi_ename.cc regarding realloc handling (since we're pivoting to mimalloc, not sure what that will look like so left it alone for now). I also tried out some suggestions from the "Performance" category.