Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues identified by cppcheck #865

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix various issues identified by cppcheck #865

merged 1 commit into from
Jan 28, 2025

Conversation

dashodanger
Copy link
Member

@dashodanger dashodanger commented Jan 28, 2025

This is a first pass/test of using cppcheck for some static analysis to help clean up the code. I've fixed all of the most severe ("Error") findings present within source_files, with the exception of one instance in epi_ename.cc regarding realloc handling (since we're pivoting to mimalloc, not sure what that will look like so left it alone for now). I also tried out some suggestions from the "Performance" category.

@pbdot pbdot merged commit b763ee0 into master Jan 28, 2025
5 checks passed
@pbdot pbdot deleted the cppcheck-fixes branch January 28, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants