Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove define & add testcase sample. #10

Closed
wants to merge 1 commit into from
Closed

remove define & add testcase sample. #10

wants to merge 1 commit into from

Conversation

hustcc
Copy link

@hustcc hustcc commented Mar 13, 2018 •
edited
Loading

Fixed #8

  • 移除所有代码中的 define，在 webpack 打包出来的 min 已经是 umd 了
  • package 中直接引用源码即可， 无需引用 dist 文件
  • 增加单测的样例，具体在 __tests__ 目录中，仅写了一个回归线的单测，其他单测可以将 readme 中的实例写进去即可，逻辑模块可以让 coverge 到 100%。
  • package 中加入三个 script，也不需要使用 build.sh 这个文件了。

后面可以做：

  • 接入 travis
  • 接入 coverage
  • 完善单测代码

希望尽快发一个版本，谢谢~

@hustcc hustcc mentioned this pull request Mar 13, 2018
Closed
@hustcc
Copy link
Author

hustcc commented Mar 15, 2018

Ping @deqingli

@hustcc hustcc closed this Mar 30, 2018
@deqingli
Copy link
Contributor

deqingli commented Apr 2, 2018

您好，我后续会看下这个 PR，感谢您给我们 提 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @deqingli