Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【建议】单测 + 移除 define #8

Closed
hustcc opened this issue Mar 7, 2018 · 2 comments
Closed

【建议】单测 + 移除 define #8

hustcc opened this issue Mar 7, 2018 · 2 comments

Comments

@hustcc
Copy link

hustcc commented Mar 7, 2018

  • 这个模块是一个纯 js 数学统计和计算的模块，应该需要一个单测来保证代码的正确性。
  • 移除 define 定义文件模块的方式，通过打包，生成最终的 dist 支持 amd（这个也是因为在 jest 环境无法引入 amd 模块文件，无法进行测试）。
@deqingli
Copy link
Contributor

单测是一直想加的，苦于没有时间，也欢迎大佬给我们提 PR

@hustcc hustcc mentioned this issue Mar 13, 2018
Closed
@hustcc
Copy link
Author

hustcc commented Mar 13, 2018

见 pr #10.

@hustcc hustcc closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hustcc @deqingli