Return error log when code generation fails; fixes #331; #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Shaodong <[email protected]>
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| GenerationResultZip output = new GenerationResultZip(informationModel,codeGenerator.getServiceKey()); |
There was a problem hiding this comment.
The Eclipse Client Toolset should not have an error.log. Instead it would be ideal, if the message is outputted to the Eclipse Console using MessageDisplay.error()
|
I thought you want to make the generation process always be successful, so that the toolset and webservice would function the same way to users. |
|
The Web service returns an error.log file back to the user while the toolset prints out the error in the console and aborts the generation. |
Signed-off-by: Ying Shaodong <[email protected]>
|
Looks great. Thanks! |
aedelmann
deleted the
feature/#331_return_error_log_when_generation_fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Shaodong [email protected]