Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error information if code generation fails, fixes #331 #336

Conversation

gavinying
Copy link
Contributor

Signed-off-by: Ying Shaodong [email protected]

@aedelmann
Copy link
Contributor

Hi Shaodong,
I saw that you are doing the exception handling in specific generator tasks. That would mean, if another generator not using the tasks that handle the error, is used, would not create this error log file , correct?

I would suggest to handle an unchecked exception in the generator client code which invokes the IVortoCodeGenerator and creates the log file and returns it. That way any code generator producing an error regardless of which generator tasks it uses, handles errors automatically. What do you think?

@gavinying gavinying closed this Jul 14, 2016
@aedelmann
Copy link
Contributor

@gavinying
I have not received any pull request with that change, we have discussed in the planning. Are you facing any issue or is it unclear?

@gavinying
Copy link
Contributor Author

@aedelmann
A little busy with other project today. Will fix it right now.

@gavinying
Copy link
Contributor Author

Created new pull request, see #338

@vlvanchin vlvanchin deleted the feature/#331_return_error_info_for_generator branch April 22, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants