Skip to content

Fix testEncodeOffsetDateTime on JDK11 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix testEncodeOffsetDateTime on JDK11 #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...nt/src/test/java/io/vertx/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import java.math.BigDecimal;
import java.time.*;
import java.util.concurrent.ThreadLocalRandom;
import java.util.function.Consumer;

@RunWith(VertxUnitRunner.class)
Expand Down Expand Up @@ -148,7 +149,17 @@ public void testEncodeDateTime(TestContext ctx) {
@Test
@Repeat(100)
public void testEncodeOffsetDateTime(TestContext ctx) {
OffsetDateTime now = LocalDateTime.now().atOffset(ZoneOffset.ofHoursMinutes(-3, -15));
/*
Starting from Java 11, LocalDateTime.now() can have microseconds precision.
But the test database defines the test_datetimeoffset column with scale of 5.

Therefore, in order to get consistent behavior between Java 8 and Java 11,
we erase the nanoOfSecond value obtained from the clock with a random number
which has at most tens of microseconds precision.
*/
int nanoOfSecond = ThreadLocalRandom.current().nextInt(100_000) * 10_000;
OffsetDateTime now = LocalDateTime.now().withNano(nanoOfSecond)
.atOffset(ZoneOffset.ofHoursMinutes(-3, -15));
testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_datetimeoffset", now, row -> {
ColumnChecker.checkColumn(0, "test_datetimeoffset")
.returns(Tuple::getValue, Row::getValue, now)
Expand Down